Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk 50 #3808

Closed
wants to merge 71 commits into from
Closed

sdk 50 #3808

Show file tree
Hide file tree
Changes from 47 commits
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
5475dfb
sdk 50 first go
faddat Jun 9, 2023
429d933
add go workspace
faddat Jun 9, 2023
7b82e42
make proto-gen, cleanup
faddat Jun 9, 2023
0ea95e9
additiona cleanup of imports
faddat Jun 9, 2023
8a22326
updates...
faddat Jun 9, 2023
5da60cb
handle expedited proposal bools
faddat Jun 10, 2023
4580f76
restructure modules
faddat Jun 10, 2023
731dc38
pre revert commit
faddat Jun 10, 2023
5f9b832
Revert "restructure modules"
faddat Jun 10, 2023
d9ddc54
correctly migrate modules
faddat Jun 10, 2023
2f76d3f
migrate parameter store
faddat Jun 10, 2023
8ca6678
fix calls to NewContext
faddat Jun 10, 2023
428c09e
tidy and enable thelper
faddat Jun 10, 2023
fc0e782
use thelper and disable depguard
faddat Jun 10, 2023
1bae599
use latest golangci-lint in ci
faddat Jun 10, 2023
635a62e
upgrade to go 1.20 and newer protobuf builder to reduce v50 changeset
faddat Jun 10, 2023
ac1c6a6
Merge remote-tracking branch 'fork/go1.20' into sdk-50
faddat Jun 10, 2023
3b34fe1
Merge remote-tracking branch 'fork/use-thelper' into sdk-50
faddat Jun 10, 2023
d90ce0b
more cleanup, 5% of tests pass
faddat Jun 10, 2023
e128eba
add go work
faddat Jun 10, 2023
2598fd1
bumps
faddat Jun 10, 2023
20b10e9
bump go in an additional place
faddat Jun 10, 2023
2464581
Merge branch 'go1.20' of https://github.com/faddat/ibc-go into go1.20
faddat Jun 10, 2023
a798db8
set up rootmultistore in the new way and address WrongArgCount lints
faddat Jun 10, 2023
02a7a70
app.go and queries
faddat Jun 10, 2023
b782566
chain.go
faddat Jun 10, 2023
3bbb027
query command in root.go
faddat Jun 10, 2023
bf859e0
context should go first
faddat Jun 10, 2023
66eda5d
Merge branch 'main' into sdk-50
faddat Jun 10, 2023
7ffb56c
additional cleanup, mainly changing method signatures
faddat Jun 11, 2023
e332c3c
Merge branch 'sdk-50' of https://github.com/notional-labs/ibc-go into…
faddat Jun 11, 2023
c234b90
update message signatures and use sdk main branch
faddat Jun 11, 2023
aaaf012
Merge branch 'main' into go1.20
faddat Jun 12, 2023
7308c14
transfer authorization changes
faddat Jun 12, 2023
8279fdd
move go.work.example back
faddat Jun 12, 2023
34f9eb3
bump go version
crodriguezvega Jun 12, 2023
7a0392d
Merge branch 'main' into go1.20
faddat Jun 12, 2023
dd3b04b
use single quotes for the go version
faddat Jun 12, 2023
63c2b18
use sdk 50
sontrinh16 Jun 12, 2023
c8e6213
Merge branch 'main' into go1.20
colin-axner Jun 12, 2023
3d8369a
Merge branch 'main' into go1.20
faddat Jun 12, 2023
71a01df
Revert "use single quotes for the go version"
faddat Jun 12, 2023
c17de1f
use single quotes for real
faddat Jun 12, 2023
77825f9
Merge branch 'go1.20' into sdk-50
faddat Jun 12, 2023
509c18b
tidy
faddat Jun 12, 2023
1e3b686
fix
sontrinh16 Jun 13, 2023
527955c
Merge branch 'sdk-50' of https://github.com/notional-labs/ibc-go into…
sontrinh16 Jun 13, 2023
ed4c730
chore: adding exception to linter config for revive if-return (#3830)
damiannolan Jun 13, 2023
98da595
build(deps): Bump docker/build-push-action from 4.1.0 to 4.1.1 (#3834)
dependabot[bot] Jun 13, 2023
9ee95c9
build(deps): Bump docker/metadata-action from 4.5.0 to 4.6.0 (#3833)
dependabot[bot] Jun 13, 2023
c8017c9
Merge remote-tracking branch 'origin/main' into sdk-50
faddat Jun 13, 2023
0d1fecd
update .gitignore
faddat Jun 13, 2023
447963c
tidies again
faddat Jun 14, 2023
e70280a
fixing
sontrinh16 Jun 14, 2023
6d2dc6a
Merge branch 'sdk-50' of https://github.com/notional-labs/ibc-go into…
sontrinh16 Jun 14, 2023
97a402e
register modulebasicmanager in app.go
faddat Jun 15, 2023
749db69
add module register in app.go
sontrinh16 Jun 15, 2023
fd5367d
Merge branch 'sdk-50' of https://github.com/notional-labs/ibc-go into…
sontrinh16 Jun 15, 2023
55d10b3
fix the upgrade module's return
faddat Jun 15, 2023
df0d6fe
all errors now checked
faddat Jun 15, 2023
f0eaa04
update FinalizeBlock height input
sontrinh16 Jun 15, 2023
5e59727
revert changes to the capability module path
faddat Jun 16, 2023
6e16d62
add circuit breaker
faddat Jun 16, 2023
30e82a8
Begin to use modulebasicmanager
faddat Jun 16, 2023
9fd734d
rename Marshaler to Codec
faddat Jun 16, 2023
f28d925
account for modulebasicmanager
faddat Jun 16, 2023
14bf431
fix setup()
faddat Jun 16, 2023
8ea5264
fix import cycle
faddat Jun 16, 2023
7323ad1
use appcodec for setuptestingapp
faddat Jun 16, 2023
cf9f253
add missing IBCKeeper initialize and remove unused module from module…
sontrinh16 Jun 17, 2023
3d58b82
update SetupWithGenesisValSet func
sontrinh16 Jun 17, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/capability.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
go-arch: ["amd64", "arm", "arm64"]
go-arch: ['amd64', 'arm', 'arm64']
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: 1.19
go-version: '1.20'
- name: Build capability-module
run: |
cd modules/capability
Expand All @@ -29,7 +29,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: 1.19
go-version: '1.20'
- name: Go Test
run: |
cd modules/capability
Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/e2e-compatibility-workflow-call.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
required: true
type: string
test-suite:
description: "Test suite to run"
description: 'Test suite to run'
required: true
type: string

Expand All @@ -19,7 +19,7 @@ jobs:
- uses: actions/checkout@v3
- uses: andstor/file-existence-action@v2
with:
files: ".github/compatibility-test-matrices/${{ inputs.test-file-directory }}/${{ inputs.test-suite }}.json"
files: '.github/compatibility-test-matrices/${{ inputs.test-file-directory }}/${{ inputs.test-suite }}.json'
- run: |
# use jq -c to compact the full json contents into a single line. This is required when using the json body
# to create the matrix in the following job.
Expand All @@ -43,7 +43,7 @@ jobs:
repository: cosmos/ibc-go
- uses: actions/setup-go@v4
with:
go-version: 1.19
go-version: '1.20'
- name: Run e2e Test
run: |
cd e2e
Expand All @@ -53,17 +53,17 @@ jobs:
# Note: this is significant as the standard behaviour when running e2es on PRs
# is that there is a set of env vars that are the same for each run. e.g. the same docker image is used
# for every test. With compatibility tests, each test may be running different combinations of images.
CHAIN_IMAGE: "${{ matrix.chain-image }}"
CHAIN_A_TAG: "${{ matrix.chain-a }}"
CHAIN_B_TAG: "${{ matrix.chain-b }}"
CHAIN_BINARY: "${{ matrix.chain-binary }}"
RELAYER_TYPE: "${{ matrix.relayer-type }}"
CHAIN_IMAGE: '${{ matrix.chain-image }}'
CHAIN_A_TAG: '${{ matrix.chain-a }}'
CHAIN_B_TAG: '${{ matrix.chain-b }}'
CHAIN_BINARY: '${{ matrix.chain-binary }}'
RELAYER_TYPE: '${{ matrix.relayer-type }}'
- name: Upload Diagnostics
uses: actions/upload-artifact@v3
# we only want to upload logs on test failures.
if: ${{ failure() }}
continue-on-error: true
with:
name: "${{ matrix.entrypoint }}-${{ matrix.test }}"
name: '${{ matrix.entrypoint }}-${{ matrix.test }}'
path: e2e/diagnostics
retention-days: 5
12 changes: 6 additions & 6 deletions .github/workflows/e2e-fork.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ on:
branches:
- main
paths-ignore:
- "docs/**"
- "**.md"
- "LICENSE"
- 'docs/**'
- '**.md'
- 'LICENSE'

jobs:
# dynamically build a matrix of test/test suite pairs to run
Expand All @@ -20,11 +20,11 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: 1.19
go-version: '1.20'
- id: set-matrix
run: echo "matrix=$(go run cmd/build_test_matrix/main.go)" >> $GITHUB_OUTPUT
env:
TEST_EXCLUSIONS: "TestInterTxTestSuite,TestIncentivizedInterTxTestSuite,TestUpgradeTestSuite"
TEST_EXCLUSIONS: 'TestInterTxTestSuite,TestIncentivizedInterTxTestSuite,TestUpgradeTestSuite'

e2e:
env:
Expand All @@ -45,7 +45,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v4
with:
go-version: 1.19
go-version: '1.20'
- name: Run e2e Test
run: |
cd e2e
Expand Down
72 changes: 36 additions & 36 deletions .github/workflows/e2e-test-workflow-call.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,68 +2,68 @@ on:
workflow_call:
inputs:
test-entry-point:
description: "Test entry point"
description: 'Test entry point'
required: false
type: string
default: "" # empty string means run all tests
default: '' # empty string means run all tests
test:
description: "test name to run as standalone"
description: 'test name to run as standalone'
required: false
type: string
default: ""
default: ''
test-exclusions:
description: "Comma separated list of tests to skip"
description: 'Comma separated list of tests to skip'
required: false
type: string
default: "" # empty string means don't skip any test.
default: '' # empty string means don't skip any test.
chain-image:
description: "The image to use for chains"
description: 'The image to use for chains'
required: true
type: string
default: "ghcr.io/cosmos/ibc-go-simd"
default: 'ghcr.io/cosmos/ibc-go-simd'
chain-a-tag:
description: "The tag to use for chain A"
description: 'The tag to use for chain A'
required: true
type: string
default: main
chain-b-tag:
default: main
description: "The tag to use for chain B"
description: 'The tag to use for chain B'
required: true
type: string
chain-binary:
default: "simd"
description: "The chain binary"
default: 'simd'
description: 'The chain binary'
required: false
type: string
chain-upgrade-tag:
default: ""
description: "The image tag that the chain will be upgraded to"
default: ''
description: 'The image tag that the chain will be upgraded to'
required: false
type: string
# upgrade-plan-name is only required during upgrade tests, and is otherwise ignored.
upgrade-plan-name:
default: ""
description: "The upgrade plan name"
default: ''
description: 'The upgrade plan name'
required: false
type: string
relayer-type:
description: "The type of relayer to use"
description: 'The type of relayer to use'
required: false
default: "rly"
default: 'rly'
type: string
relayer-tag:
description: "The tag to use for the relayer"
description: 'The tag to use for the relayer'
required: false
default: "" # the tests themselves will choose a sensible default when unset.
default: '' # the tests themselves will choose a sensible default when unset.
type: string
build-and-push-docker-image:
description: "Flag to specify if the docker image should be built and pushed beforehand"
description: 'Flag to specify if the docker image should be built and pushed beforehand'
required: false
type: boolean
default: false
upload-logs:
description: "Specify flag to indicate that logs should be uploaded on failure"
description: 'Specify flag to indicate that logs should be uploaded on failure'
required: false
type: boolean
default: false
Expand Down Expand Up @@ -138,13 +138,13 @@ jobs:
repository: cosmos/ibc-go
- uses: actions/setup-go@v4
with:
go-version: 1.19
go-version: '1.20'
- id: set-matrix
run: echo "matrix=$(go run cmd/build_test_matrix/main.go)" >> $GITHUB_OUTPUT
env:
TEST_ENTRYPOINT: "${{ inputs.test-entry-point }}"
TEST_EXCLUSIONS: "${{ inputs.test-exclusions }}"
TEST_NAME: "${{ inputs.test }}"
TEST_ENTRYPOINT: '${{ inputs.test-entry-point }}'
TEST_EXCLUSIONS: '${{ inputs.test-exclusions }}'
TEST_NAME: '${{ inputs.test }}'

# e2e-tests runs the actual go test command to trigger the test.
# the tests themselves are configured via environment variables to specify
Expand All @@ -155,14 +155,14 @@ jobs:
- build-test-matrix
- docker-build
env:
CHAIN_IMAGE: "${{ inputs.chain-image }}"
CHAIN_A_TAG: "${{ inputs.chain-a-tag }}"
CHAIN_B_TAG: "${{ inputs.chain-b-tag }}"
RELAYER_TAG: "${{ inputs.relayer-tag }}"
RELAYER_TYPE: "${{ inputs.relayer-type }}"
CHAIN_BINARY: "${{ inputs.chain-binary }}"
CHAIN_UPGRADE_TAG: "${{ inputs.chain-upgrade-tag }}"
CHAIN_UPGRADE_PLAN: "${{ inputs.upgrade-plan-name }}"
CHAIN_IMAGE: '${{ inputs.chain-image }}'
CHAIN_A_TAG: '${{ inputs.chain-a-tag }}'
CHAIN_B_TAG: '${{ inputs.chain-b-tag }}'
RELAYER_TAG: '${{ inputs.relayer-tag }}'
RELAYER_TYPE: '${{ inputs.relayer-type }}'
CHAIN_BINARY: '${{ inputs.chain-binary }}'
CHAIN_UPGRADE_TAG: '${{ inputs.chain-upgrade-tag }}'
CHAIN_UPGRADE_PLAN: '${{ inputs.upgrade-plan-name }}'
strategy:
fail-fast: false
matrix: ${{ fromJSON(needs.build-test-matrix.outputs.matrix) }}
Expand All @@ -172,7 +172,7 @@ jobs:
repository: cosmos/ibc-go
- uses: actions/setup-go@v4
with:
go-version: 1.19
go-version: '1.20'
- name: Run e2e Test
id: e2e_test
run: |
Expand All @@ -183,6 +183,6 @@ jobs:
if: ${{ failure() && inputs.upload-logs }}
continue-on-error: true
with:
name: "${{ matrix.entrypoint }}-${{ matrix.test }}"
name: '${{ matrix.entrypoint }}-${{ matrix.test }}'
path: e2e/diagnostics
retention-days: 5
132 changes: 66 additions & 66 deletions .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,73 +10,73 @@ on:
# trigger workflow if PR is marked ready for review.
- ready_for_review
paths-ignore:
- "docs/**"
- "**.md"
- "LICENSE"
- 'docs/**'
- '**.md'
- 'LICENSE'

jobs:
# determine-image-tag will either output the PR number e.g. pr-1234 or the string main.
# this will be used to tag the images that are built during the workflow.
determine-image-tag:
if: ${{ !github.event.pull_request.draft && !github.event.pull_request.head.repo.fork && github.actor != 'dependabot[bot]' }}
runs-on: ubuntu-latest
outputs:
simd-tag: ${{ steps.get-tag.outputs.simd-tag }}
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: 1.18
- id: get-tag
run: |
if [ -z "${{ github.event.pull_request.number }}" ]
then
echo "simd-tag=main" >> $GITHUB_OUTPUT
else
tag="pr-${{ github.event.pull_request.number }}"
echo "Using tag $tag"
echo "simd-tag=$tag" >> $GITHUB_OUTPUT
fi
# determine-image-tag will either output the PR number e.g. pr-1234 or the string main.
# this will be used to tag the images that are built during the workflow.
determine-image-tag:
if: ${{ !github.event.pull_request.draft && !github.event.pull_request.head.repo.fork && github.actor != 'dependabot[bot]' }}
runs-on: ubuntu-latest
outputs:
simd-tag: ${{ steps.get-tag.outputs.simd-tag }}
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: '1.20'
- id: get-tag
run: |
if [ -z "${{ github.event.pull_request.number }}" ]
then
echo "simd-tag=main" >> $GITHUB_OUTPUT
else
tag="pr-${{ github.event.pull_request.number }}"
echo "Using tag $tag"
echo "simd-tag=$tag" >> $GITHUB_OUTPUT
fi

# build-e2e ensures that all test code compiles.
build-e2e:
if: ${{ !github.event.pull_request.draft && !github.event.pull_request.head.repo.fork && github.actor != 'dependabot[bot]' }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: 1.19
- name: Build e2e
run: |
cd e2e
find ./tests -type d | while IFS= read -r dir
do
if ls "${dir}"/*.go >/dev/null 2>&1; then
GOARCH=arm64 go test -c "$dir" 2>/dev/null
fi
done
# build-e2e ensures that all test code compiles.
build-e2e:
if: ${{ !github.event.pull_request.draft && !github.event.pull_request.head.repo.fork && github.actor != 'dependabot[bot]' }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: '1.20'
- name: Build e2e
run: |
cd e2e
find ./tests -type d | while IFS= read -r dir
do
if ls "${dir}"/*.go >/dev/null 2>&1; then
GOARCH=arm64 go test -c "$dir" 2>/dev/null
fi
done

e2e:
# we will be running this job if the PR has not yet been marked for review, and we push additional changes.
# we skip the job in this case.
if: ${{ !github.event.pull_request.draft && !github.event.pull_request.head.repo.fork && github.actor != 'dependabot[bot]' }}
needs:
- determine-image-tag # we are required to have a docker tag before we can build any images.
- build-e2e # don't attempt any tests unless the e2e code compiles successfully.
uses: ./.github/workflows/e2e-test-workflow-call.yml
# unless we explicitly tell the workflow to inherit secrets, required secrets such as GITHUB_TOKEN will not be
# provided to the workflow. This would cause privileged operations to fail.
secrets: inherit
with:
# with each test, we build an image from the current code.
build-and-push-docker-image: true
# if the test fails, we upload logs so that we can download them from the UI.
upload-logs: true
chain-image: ghcr.io/cosmos/ibc-go-simd
# with regular tests, both images are the same.
chain-a-tag: "${{ needs.determine-image-tag.outputs.simd-tag }}"
chain-b-tag: "${{ needs.determine-image-tag.outputs.simd-tag }}"
chain-binary: "simd"
# on regular PRs we won't run interchain account or upgrade tests.
test-exclusions: "TestInterTxTestSuite,TestIncentivizedInterTxTestSuite,TestUpgradeTestSuite"
e2e:
# we will be running this job if the PR has not yet been marked for review, and we push additional changes.
# we skip the job in this case.
if: ${{ !github.event.pull_request.draft && !github.event.pull_request.head.repo.fork && github.actor != 'dependabot[bot]' }}
needs:
- determine-image-tag # we are required to have a docker tag before we can build any images.
- build-e2e # don't attempt any tests unless the e2e code compiles successfully.
uses: ./.github/workflows/e2e-test-workflow-call.yml
# unless we explicitly tell the workflow to inherit secrets, required secrets such as GITHUB_TOKEN will not be
# provided to the workflow. This would cause privileged operations to fail.
secrets: inherit
with:
# with each test, we build an image from the current code.
build-and-push-docker-image: true
# if the test fails, we upload logs so that we can download them from the UI.
upload-logs: true
chain-image: ghcr.io/cosmos/ibc-go-simd
# with regular tests, both images are the same.
chain-a-tag: '${{ needs.determine-image-tag.outputs.simd-tag }}'
chain-b-tag: '${{ needs.determine-image-tag.outputs.simd-tag }}'
chain-binary: 'simd'
# on regular PRs we won't run interchain account or upgrade tests.
test-exclusions: 'TestInterTxTestSuite,TestIncentivizedInterTxTestSuite,TestUpgradeTestSuite'
Loading