Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(atomic): add interfaces for functional lit components #5000

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

alexprudhomme
Copy link
Contributor

@alexprudhomme alexprudhomme commented Feb 20, 2025

https://coveord.atlassian.net/browse/KIT-3990

This will be helpful as it will be easier to create new functions with this and simpler to use since all components will have :

props :{},
children: ...

Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 243.7 243.7 0
commerce 355 355 0
search 415 415 0
insight 406.2 406.2 0
recommendation 255.9 255.9 0
ssr 408.8 408.8 0
ssr-commerce 372.7 372.7 0

Base automatically changed from KIT-3989 to master February 21, 2025 17:45
@github-actions github-actions bot requested a review from a team as a code owner February 21, 2025 17:45
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants