Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(headless-commerce-react): prevent duplicate /querySuggest request in samples #5003

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(headless-commerce-react): prevent duplicate /querySuggest request in samples #5003

wants to merge 1 commit into from
+0 −2

Conversation

y-lakhdar
Copy link
Contributor

updateText already calls showSuggestions()
https://coveord.atlassian.net/browse/KIT-3992

@y-lakhdar y-lakhdar requested a review from a team as a code owner February 21, 2025 16:42
@github-actions GitHub Actions
Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 243.7 243.7 0
commerce 355 355 0
search 415 415 0
insight 406.2 406.2 0
recommendation 255.9 255.9 0
ssr 408.8 408.8 0
ssr-commerce 372.7 372.7 0

@y-lakhdar y-lakhdar added this pull request to the merge queue Feb 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 21, 2025
@y-lakhdar y-lakhdar added this pull request to the merge queue Feb 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexprudhomme alexprudhomme alexprudhomme approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/search

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/search

@louis-bompart louis-bompart Awaiting requested review from louis-bompart louis-bompart is a code owner automatically assigned from coveo/search

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@y-lakhdar @alexprudhomme