Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to give warning instead of failing the build if coverage is below threshold #1670

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

roostaamir
Copy link

- This will enable the option to choose if the build should fail when
  the coverage is below the threshold or just give a warning about it
@roostaamir
Copy link
Author

To the reviewer:

I need a bit of help to decide where to write tests for the new functionality. Could you please give me a suggestion about where would be the best test project to write test for this newly introduced parameter?

Thanks in advance

@roostaamir
Copy link
Author

@dotnet-policy-service agree

@roostaamir
Copy link
Author

Hi again

Are there any updates about comments or reviews on my PR?

@roostaamir roostaamir changed the title Add ThresholdAct option to MSBuild task Add option to give warning instead of failing the build if coverage is below threshold Aug 13, 2024
@Bertk
Copy link
Collaborator

Bertk commented Sep 1, 2024

Thank you for the contribution.

Maybe an additional test in DotnetTool.cs should verify the new command line option.

By the way, I would use bool ThresholdWarn instead of enum ThresholdAction.

Unfortunately, I do not have the PR approve permission. @MarcoRossignoli, @daveMueller Could you please review this PR.

@MarcoRossignoli
Copy link
Collaborator

Maybe an additional test in DotnetTool.cs should verify the new command line option.

I agree could be good add some tests for it

@roostaamir
Copy link
Author

Thank you very much @Bertk and @MarcoRossignoli

I will make the requested changes and update the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants