-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to give warning instead of failing the build if coverage is below threshold #1670
base: master
Are you sure you want to change the base?
Add option to give warning instead of failing the build if coverage is below threshold #1670
Conversation
roostaamir
commented
Jul 10, 2024
- This will enable the option to choose if the build should fail when the coverage is below the threshold or just give a warning about it
- Based on the initial idea that started here: Add possibility to give warning when coverage is below the threshold instead of just failing the build #701
- This will enable the option to choose if the build should fail when the coverage is below the threshold or just give a warning about it
…staamir/coverlet into add-threshold-warning-option
To the reviewer: I need a bit of help to decide where to write tests for the new functionality. Could you please give me a suggestion about where would be the best test project to write test for this newly introduced parameter? Thanks in advance |
@dotnet-policy-service agree |
Hi again Are there any updates about comments or reviews on my PR? |
Thank you for the contribution. Maybe an additional test in DotnetTool.cs should verify the new command line option. By the way, I would use Unfortunately, I do not have the PR approve permission. @MarcoRossignoli, @daveMueller Could you please review this PR. |
I agree could be good add some tests for it |
Thank you very much @Bertk and @MarcoRossignoli I will make the requested changes and update the PR :) |