Fix Swift Testing Capture Groups #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
=======================================
Coverage 90.91% 90.91%
=======================================
Files 17 17
Lines 2454 2454
=======================================
Hits 2231 2231
Misses 223 223 ☔ View full report in Codecov by Sentry. |
cpisciotta
force-pushed
the
charles/SwiftTestingTestPassedCaptureGroup
branch
from
3d59e39 to
443fefc
Compare
cpisciotta
changed the title
cpisciotta
force-pushed
the
charles/SwiftTestingTestPassedCaptureGroup
branch
from
443fefc to
9910af1
Compare
cpisciotta
force-pushed
the
charles/SwiftTestingTestPassedCaptureGroup
branch
from
9910af1 to
453db5a
Compare
cpisciotta
commented
Feb 11, 2025
| @@ -2010,7 +2010,7 @@ struct SwiftTestingRunStartedCaptureGroup: CaptureGroup { | |||
|
|
|||
| /// Regular expression to capture the start of a test run. | |||
| /// $1 = message | |||
| static let regex = XCRegex(pattern: #"^.\s+(Test run started\.)$"#) | |||
| static let regex = XCRegex(pattern: #"^ (Test run started\.)$"#) | |||
There was a problem hiding this comment.
Note: There's a special character at the start of these regexes that GitHub doesn't render.
cpisciotta
commented
Feb 11, 2025
| @@ -171,7 +171,7 @@ final class ParserTests: XCTestCase { | |||
| } | |||
|
|
|||
| func testMatchSwiftTestingRunStarted() throws { | |||
| let input = " Test run started." | |||
| let input = " Test run started." | |||
There was a problem hiding this comment.
Checked against example project using Swift Testing. Updated these since they need two spaces – as seen in swift_test_log.txt. These files don't render the leading symbol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.