Cleanup visitor test data #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Formatting check succeeded! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #568 +/- ##
============================================
+ Coverage 73.33% 73.34% +0.01%
Complexity 19 19
============================================
Files 363 363
Lines 19357 19357
Branches 2954 2954
============================================
+ Hits 14195 14198 +3
+ Misses 3736 3734 -2
+ Partials 1426 1425 -1 ☔ View full report in Codecov by Sentry. |
-Updated tests to reflect file change -Apply spotless
-Use Bundle-small-approved-draft in it's place, update test assertions to reflect
TahaAttari
reviewed
Nov 6, 2024
...ir-utility/src/test/java/org/opencds/cqf/fhir/utility/visitor/dstu3/ReleaseVisitorTests.java
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have excessively large test bundles being used in the Visitor tests. They are useful for the eCR plugin to be more representative of the real VSM data with its idiosyncracies but are bloat for this project.
Trimming those bundles down to the minimum information which is sufficient to test functionality