Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add propagateElements method and events in 3.2 #4139

Closed
putyourlightson opened this issue Apr 13, 2019 · 5 comments
Closed
Labels
enhancement improvements to existing features extensibility 🔌 features related to plugin/module dev

Comments

@putyourlightson
Copy link

putyourlightson commented Apr 13, 2019

Feature request to add a propagateElements method and events to the Elements service in Craft 3.2.

Something similar was done with resaveElements in 5b0cd57 and the same logic could hopefully be applied to propagating elements. I'd be happy to submit a PR but I assume you probably want to follow your own pattern in the implementation of this.

@brandonkelly brandonkelly added extensibility 🔌 features related to plugin/module dev enhancement improvements to existing features labels Apr 16, 2019
@brandonkelly brandonkelly added this to the 3.2 milestone Apr 16, 2019
@putyourlightson
Copy link
Author

FYI since 3.2.0-alpha.4 changed the behaviour back to propagating elements immediately on save, this is less of a priority than previously, and possible not even necessary.

craft\services\Elements::saveElement() now immediately propagates elements if $propagate is true, as it used to.

@brandonkelly
Copy link
Member

I’ll probably land somewhere in between, where most of the time we propagate over a background task. But there were cases where the blanket approach was an issue.

@putyourlightson
Copy link
Author

Ok, I'll wait and see where this ends up, thanks!

brandonkelly added a commit that referenced this issue May 24, 2019
@brandonkelly
Copy link
Member

Added propagateElements() for the next 3.2 Alpha release.

@putyourlightson
Copy link
Author

Thanks Brandon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvements to existing features extensibility 🔌 features related to plugin/module dev
Projects
None yet
Development

No branches or pull requests

1 participant