-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup project config setup in tests #4804
Merged
angrybrad
merged 14 commits into
craftcms:develop
from
gtettelaar:fix/project-config-testing-cleanup
Aug 23, 2019
Merged
Cleanup project config setup in tests #4804
angrybrad
merged 14 commits into
craftcms:develop
from
gtettelaar:fix/project-config-testing-cleanup
Aug 23, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4804 +/- ##
============================================
- Coverage 31.51% 31.5% -0.01%
- Complexity 12922 12927 +5
============================================
Files 530 530
Lines 38668 38676 +8
============================================
Hits 12186 12186
- Misses 26482 26490 +8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #4711. It's smart to clean up and provide a better warning if someone specifies a project config file in
codeception.yml
but doesn't enableuseProjectConfigFile
ingeneral.php
.PR also contains some general cleanup.