Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup project config setup in tests #4804

Merged

Conversation

gtettelaar
Copy link
Contributor

Addressing #4711. It's smart to clean up and provide a better warning if someone specifies a project config file in codeception.yml but doesn't enable useProjectConfigFile in general.php.

PR also contains some general cleanup.

@gtettelaar gtettelaar requested a review from angrybrad August 23, 2019 13:03
@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #4804 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #4804      +/-   ##
============================================
- Coverage      31.51%   31.5%   -0.01%     
- Complexity     12922   12927       +5     
============================================
  Files            530     530              
  Lines          38668   38676       +8     
============================================
  Hits           12186   12186              
- Misses         26482   26490       +8
Impacted Files Coverage Δ Complexity Δ
src/test/TestSetup.php 0% <0%> (ø) 48 <12> (+4) ⬆️
src/test/Craft.php 33.16% <0%> (-0.35%) 68 <1> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82e14b2...932cd12. Read the comment docs.

@angrybrad angrybrad merged commit ea75088 into craftcms:develop Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants