-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7122] Workflow is not cancelled when renaming an item's parent #4380
base: develop
Are you sure you want to change the base?
Conversation
ui/app/src/components/CreateFolderDialog/CreateFolderContainer.tsx
Outdated
Show resolved
Hide resolved
…and error handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Review, understand (ask questions) and test the changes I've pushed
- One scenario I'm not too clear on how it works in practice is the suggested modified value being a path that exists. Please test and lets review that scenario
ui/app/src/components/CreateFolderDialog/CreateFolderContainer.tsx
Outdated
Show resolved
Hide resolved
ui/app/src/components/CreateFolderDialog/CreateFolderContainer.tsx
Outdated
Show resolved
Hide resolved
Reviewed changes, tested the different scenarios. |
@rart I updated the workflow warning message to be the same as in ViewPackagesDialog ( |
ui/app/src/components/CreateFolderDialog/CreateFolderContainer.tsx
Outdated
Show resolved
Hide resolved
ui/app/src/components/CreateFolderDialog/CreateFolderContainer.tsx
Outdated
Show resolved
Hide resolved
<PrimaryButton onClick={onSubmit} disabled={isSubmitting || !isValid} loading={isSubmitting}> | ||
<PrimaryButton | ||
onClick={onSubmit} | ||
disabled={isSubmitting || !isValid || fetchingAffectedPackages} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disabled={isSubmitting || !isValid || fetchingAffectedPackages} | |
disabled={!isValid} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would lose the isSubmitting
validation, should I keep it here or add it to the isValid
var?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isSubmitting is considered by the loading prop of the button
craftercms/craftercms#7122