Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI can not push to DockerHub #607

Closed
Emilgardis opened this issue Nov 9, 2021 · 1 comment · Fixed by #609
Closed

CI can not push to DockerHub #607

Emilgardis opened this issue Nov 9, 2021 · 1 comment · Fixed by #609
Labels
meta issues/PRs related to the maintenance of the crate.

Comments

@Emilgardis
Copy link
Member

CI is currently unable to push to DH as it used a password, password authentication was disabled sometime lately.

We need to update the specified password secret to use a token instead.
@Emilgardis Emilgardis mentioned this issue Nov 9, 2021
Merged
@adamgreig
Copy link
Member

This seems tricky: as far as I can tell, DockerHub recently changed their pricing model so free teams can only have 3 members and also you need to use a specific account's personal access token to have CI push images. Together that means we'd probably need to remove 4 of the 6 current team members, make a new machine account (is that allowed?), add it to the team, and use its PAT in CI.

Ooooor swap to GHA+GHCR.

@Emilgardis Emilgardis mentioned this issue Nov 18, 2021
Merged
9 tasks
@Emilgardis Emilgardis linked a pull request Jan 24, 2022 that will close this issue
switch to GHCR and use more github actions #609
Merged
9 tasks
bors bot added a commit that referenced this issue Mar 13, 2022
@bors @Emilgardis
@malbarbo @jszwedko @wg @svenstaro @josephlr @reitermarkus
Merge #609
6c1888f 
609: switch to GHCR and use more github actions r=reitermarkus a=Emilgardis

addresses #607 #571

## what this does

- [x] change default registry to look for cross images to `ghcr.io`
- [x] move from azure CI for docker images to GHA
- [x] add clippy (that does not fail job, can be made to do this later) and rustfmt
- [x] bump QEMU to 5.1
- [ ] Add (better) layer caching

## Some nice things to have/include
- [x] Cache docker images, possibly using buildx (probably out of scope of this pr)
- [x] Use actions/cache
- [ ] make configuration easier to maintain
- [ ] possibly replace docker setup with actions

Co-authored-by: Emil Gardström <[email protected]>
Co-authored-by: Marco A L Barbosa <[email protected]>
Co-authored-by: Jesse Szwedko <[email protected]>
Co-authored-by: Will <[email protected]>
Co-authored-by: Sven-Hendrik Haase <[email protected]>
Co-authored-by: Joe Richey <[email protected]>
Co-authored-by: Markus Reiter <[email protected]>
bors bot added a commit that referenced this issue Mar 13, 2022
@bors @Emilgardis
@malbarbo @jszwedko @wg @svenstaro @josephlr @reitermarkus
Merge #609
aa1d544 
609: switch to GHCR and use more github actions r=reitermarkus a=Emilgardis

addresses #607 #571

## what this does

- [x] change default registry to look for cross images to `ghcr.io`
- [x] move from azure CI for docker images to GHA
- [x] add clippy (that does not fail job, can be made to do this later) and rustfmt
- [x] bump QEMU to 5.1
- [ ] Add (better) layer caching

## Some nice things to have/include
- [x] Cache docker images, possibly using buildx (probably out of scope of this pr)
- [x] Use actions/cache
- [ ] make configuration easier to maintain
- [ ] possibly replace docker setup with actions

Co-authored-by: Emil Gardström <[email protected]>
Co-authored-by: Marco A L Barbosa <[email protected]>
Co-authored-by: Jesse Szwedko <[email protected]>
Co-authored-by: Will <[email protected]>
Co-authored-by: Sven-Hendrik Haase <[email protected]>
Co-authored-by: Joe Richey <[email protected]>
Co-authored-by: Markus Reiter <[email protected]>
bors bot added a commit that referenced this issue Mar 13, 2022
@bors @Emilgardis
@malbarbo @jszwedko @wg @svenstaro @josephlr @reitermarkus
Merge #609
5a0260b 
609: switch to GHCR and use more github actions r=reitermarkus a=Emilgardis

addresses #607 #571

## what this does

- [x] change default registry to look for cross images to `ghcr.io`
- [x] move from azure CI for docker images to GHA
- [x] add clippy (that does not fail job, can be made to do this later) and rustfmt
- [x] bump QEMU to 5.1
- [ ] Add (better) layer caching

## Some nice things to have/include
- [x] Cache docker images, possibly using buildx (probably out of scope of this pr)
- [x] Use actions/cache
- [ ] make configuration easier to maintain
- [ ] possibly replace docker setup with actions

Co-authored-by: Emil Gardström <[email protected]>
Co-authored-by: Marco A L Barbosa <[email protected]>
Co-authored-by: Jesse Szwedko <[email protected]>
Co-authored-by: Will <[email protected]>
Co-authored-by: Sven-Hendrik Haase <[email protected]>
Co-authored-by: Joe Richey <[email protected]>
Co-authored-by: Markus Reiter <[email protected]>
@bors bors bot closed this as completed in #609 Mar 14, 2022
@Alexhuszagh Alexhuszagh added the meta issues/PRs related to the maintenance of the crate. label Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta issues/PRs related to the maintenance of the crate.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

switch to GHCR and use more github actions Emilgardis/cross
3 participants
@adamgreig @Emilgardis @Alexhuszagh