Add support for emscripten targets #106
Conversation
As of now, xargo cannot be build
|
This was inspired by #36, but I expected that the PR would be different that I wrote it from the beginning. |
|
Tested this with some local projects and it worked fine. Projects using libc generally fails, it seems that libc for emscripten targets are broken, I'm working on it. |
There was a problem hiding this comment.
Thanks @malbarbo. This is really nice!
Projects using libc generally fails, it seems that libc for emscripten targets are broken, I'm working on it.
I'd be fine landing this and adding a note to the README that some projects that use libc may fail.
docker/node-wasm
Outdated
| # Workaround for | ||
| # https://github.com/kripken/emscripten/issues/4542 | ||
|
|
||
| if [ "$(basename $path)" != "deps" ]; then |
There was a problem hiding this comment.
Could you add a comment here indicating what kind of paths we expect to see here and why we have to branch here and in the if below?
|
Done. |
|
Thanks @malbarbo ❤️ @homunkulus r+ |
|
📌 Commit d1d7253 has been approved by |
|
☀️ Test successful - status-travis |
Emscripten 1.37.13 provides pre-build binaries, so we do not need to build it.
Node 8.0.0 can exec wasm files, so we can have test support for both asmjs and wasm32. We use a workaround for emscripten-core/emscripten#4542.