Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): improve installation step #307

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Conversation

bang9
Copy link
Contributor

@bang9 bang9 commented May 26, 2022

Description

  • react-native-fireabse 를 관리하고 있는 invertase 의 gradle plugin 을 적용했습니다.
    build.gradle 의 redundant 한 코드 제거와 의존하는 sdk 버전의 관리가 한결 더 간편해집니다.
    (kakao-sdk 가 버전을 하나로 관리하는 것 같아서, 패키지별로 버전을 지정하게끔 하지는 않았습니다.)
  • root project 에 kakao maven repository 를 주입하는 스크립트를 추가했습니다.
    이제 더이상 사용자가 프로젝트 build.gradle 의 allprojects 에 따로 maven repository 를 넣지 않아도 됩니다.

Test plan

  • 샘플앱의 allprojects.repositories 의 카카오 maven url 을 제거한 상태로 빌드가 정상적으로 이루어집니다.
  • 샘플앱의 kakao sdk 버전이 정상적으로 override 되는지 확인합니다.

@bang9 bang9 changed the title feat(android): improve installtion step feat(android): improve installation step May 26, 2022
Copy link
Member

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰가 좀 늦었습니다. 전체적으로 좋아보입니다 👍

@hyochan hyochan added 🍗 enhancement New feature or request 🤖 android Related to android labels Jun 21, 2022
@bang9
Copy link
Contributor Author

bang9 commented Jun 21, 2022

@hyochan 리뷰 반영했습니다! 감사합니다 👍

Copy link
Member

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다 🙇🏻

@hyochan hyochan merged commit df904e3 into crossplatformkorea:main Jun 21, 2022
@bang9 bang9 deleted the main branch June 21, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android Related to android 🍗 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants