Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Problem: Ambiguous outputs from the client-cli #951

Closed
foreseaz opened this issue Jan 21, 2020 · 2 comments · Fixed by #959
Closed

Problem: Ambiguous outputs from the client-cli #951

foreseaz opened this issue Jan 21, 2020 · 2 comments · Fixed by #959
Assignees
Milestone

Comments

@foreseaz
Copy link

Describe the bug
Multiple ambiguous outputs of the commands should be improved to better guide the users.

  1. Missing explanations of the input params:
  • ./target/debug/client-cli wallet new --name foo --type
    image
    It's better to include all the available types and explain each when the type is missing.

  • ./target/debug/client-cli state
    image
    It's better to further explain the <name> as <wallet name>

  • etc.

  1. Duplicate outputs:
  • client-cli balance --name Default
    image
    The object of the balance is duplicated with the table liked output
@foreseaz
Copy link
Author

  1. Missing response
    client-cli transaction new --name Default --type Withdraw, there is no successful response:
    image

@foreseaz
Copy link
Author

  1. Missing \n from the response
    client-cli sync --name Default, missing \n after the successful msg

image

@tomtau tomtau added this to the CRO Sprint 23 milestone Jan 22, 2020
bors bot added a commit that referenced this issue Jan 22, 2020
959: Problem: Ambiguous outputs from client-cli r=devashishdxt a=devashishdxt

Solution: Fixed all the issues described in #951. Fixes #951 

Co-authored-by: Devashish Dixit <[email protected]>
@bors bors bot closed this as completed in 6fe7a73 Jan 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants