Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Problem: outdated send your first tx docs #56

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

foreseaz
Copy link
Contributor

@foreseaz
Copy link
Contributor Author

Encountered some problems involving running with Docker. Recorded here:
#950
#951

@tomtau tomtau changed the title Problem: update outdated send your first tx docs Problem: outdated send your first tx docs Jan 22, 2020
@tomtau
Copy link
Contributor

tomtau commented Jan 22, 2020

@foreseaz I opened this issue: crypto-com/thaler#960

Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments -- cli may have some changes in UX

Copy link
Contributor

@lezzokafka lezzokafka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your plan, once you set up a node and get the blockchain running with the default devent setting;
the next step is to allow developers to recover the wallet ( from the default seed which has funds in it) and interact with the blockchain by sending a transaction.

Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@foreseaz @lezzokafka what is the plan about this PR?

@lezzokafka
Copy link
Contributor

@foreseaz @lezzokafka what is the plan about this PR?

@foreseaz is finishing the last import/export tx bit, will be updated soon.

@lezzokafka
Copy link
Contributor

@foreseaz @lezzokafka what is the plan about this PR?

@foreseaz is finishing the last import/export tx bit, will be updated soon.

I break it and raised a new issue #92, so that @foreseaz can finish this PR first.

@foreseaz foreseaz force-pushed the docs/new-send-first-tx branch from 1248995 to 93065b5 Compare February 27, 2020 04:52
@foreseaz
Copy link
Contributor Author

Updated & pls review~ Due to my local cli env problems, I left the export & import tx commands for @lezzokafka to finish #92 Thanks.

Copy link
Contributor

@lezzokafka lezzokafka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, left some suggested changes / comments 👍

```
Then you will get the `Authentication token`, remember the token and it will be needed for all authorised commands.

- Besides, you can check the bond status of the wallet by the following command:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe put this after creating the staking address in "## Create Transfer & Staking Address"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

@foreseaz foreseaz force-pushed the docs/new-send-first-tx branch from 93065b5 to 5dcf5ea Compare March 5, 2020 04:24
@foreseaz foreseaz requested a review from tomtau March 5, 2020 06:39

The following 3 types of transactions: `TransferTx`, `DepositStakeTx` and `WithdrawUnbondedTx`, have some of their payloads obfuscated.
Sender could associate one or more `view-keys` onto the transactions. The view-key associated wallet could easily sync and view the transaction.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or zero views keys

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but that may be more advanced for "first transaction" tutorial

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and the current implementation of client-cli includes the sender view key by default anyway)

Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks all right, just the ending is unfinished -- so perhaps there should be a todo note?

```

Then, you can verify the transaction by ...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is "TODO"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one would verify it if one can use its output at the moment?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will pick it up with #92

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, so I'll just merge this one as it is


The following 3 types of transactions: `TransferTx`, `DepositStakeTx` and `WithdrawUnbondedTx`, have some of their payloads obfuscated.
Sender could associate one or more `view-keys` onto the transactions. The view-key associated wallet could easily sync and view the transaction.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and the current implementation of client-cli includes the sender view key by default anyway)

@tomtau tomtau merged commit 76e560b into crypto-com:master Mar 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants