-
Notifications
You must be signed in to change notification settings - Fork 26
Problem: outdated send your first tx
docs
#56
Conversation
send your first tx
docssend your first tx
docs
@foreseaz I opened this issue: crypto-com/thaler#960 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few comments -- cli may have some changes in UX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your plan, once you set up a node and get the blockchain running with the default devent setting;
the next step is to allow developers to recover the wallet ( from the default seed which has funds in it) and interact with the blockchain by sending a transaction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@foreseaz @lezzokafka what is the plan about this PR?
@foreseaz is finishing the last import/export tx bit, will be updated soon. |
I break it and raised a new issue #92, so that @foreseaz can finish this PR first. |
1248995
to
93065b5
Compare
Updated & pls review~ Due to my local cli env problems, I left the export & import tx commands for @lezzokafka to finish #92 Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, left some suggested changes / comments 👍
``` | ||
Then you will get the `Authentication token`, remember the token and it will be needed for all authorised commands. | ||
|
||
- Besides, you can check the bond status of the wallet by the following command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe put this after creating the staking address in "## Create Transfer & Staking Address"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved
93065b5
to
5dcf5ea
Compare
|
||
The following 3 types of transactions: `TransferTx`, `DepositStakeTx` and `WithdrawUnbondedTx`, have some of their payloads obfuscated. | ||
Sender could associate one or more `view-keys` onto the transactions. The view-key associated wallet could easily sync and view the transaction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or zero views keys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but that may be more advanced for "first transaction" tutorial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(and the current implementation of client-cli includes the sender view key by default anyway)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks all right, just the ending is unfinished -- so perhaps there should be a todo note?
``` | ||
|
||
Then, you can verify the transaction by ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is "TODO"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one would verify it if one can use its output at the moment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will pick it up with #92
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, so I'll just merge this one as it is
|
||
The following 3 types of transactions: `TransferTx`, `DepositStakeTx` and `WithdrawUnbondedTx`, have some of their payloads obfuscated. | ||
Sender could associate one or more `view-keys` onto the transactions. The view-key associated wallet could easily sync and view the transaction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(and the current implementation of client-cli includes the sender view key by default anyway)
Preview here https://crypto-chain-doc.surge.sh/getting-started/send_your_first_transaction.html