Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

chainbot fails to run after recent dev-utils change #692

Merged
merged 1 commit into from
Dec 17, 2019

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Dec 17, 2019

Solution: upgrade chainbot.

@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #692 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
- Coverage   70.14%   70.13%   -0.01%     
==========================================
  Files         131      131              
  Lines       16558    16558              
==========================================
- Hits        11614    11613       -1     
- Misses       4944     4945       +1
Impacted Files Coverage Δ
chain-core/src/common/merkle_tree.rs 98.55% <0%> (-0.25%) ⬇️

Copy link
Collaborator

@leejw51crypto leejw51crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok, I'll wait for #691 before merging

@tomtau
Copy link
Contributor

tomtau commented Dec 17, 2019

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 17, 2019

This PR was included in a batch with a merge conflict, it will be automatically retried

bors bot added a commit that referenced this pull request Dec 17, 2019
692: chainbot fails to run after recent dev-utils change r=tomtau a=yihuang

Solution: upgrade chainbot.

Co-authored-by: yihuang <[email protected]>
@bors
Copy link
Contributor

bors bot commented Dec 17, 2019

Canceled

@yihuang
Copy link
Collaborator Author

yihuang commented Dec 17, 2019

Rebased.

@tomtau
Copy link
Contributor

tomtau commented Dec 17, 2019

bors r+

bors bot added a commit that referenced this pull request Dec 17, 2019
692: chainbot fails to run after recent dev-utils change r=tomtau a=yihuang

Solution: upgrade chainbot.

Co-authored-by: yihuang <[email protected]>
@bors
Copy link
Contributor

bors bot commented Dec 17, 2019

@bors bors bot merged commit bb48d4e into crypto-com:master Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants