This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem: (CRO-654) Fix unnoticed warnings #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will first test if the TravisCI pipeline works, before applying the fix to existing warnings. |
Codecov Report
@@ Coverage Diff @@
## master #691 +/- ##
==========================================
- Coverage 70.16% 70.14% -0.02%
==========================================
Files 131 131
Lines 16559 16558 -1
==========================================
- Hits 11618 11614 -4
- Misses 4941 4944 +3
|
tomtau
requested review from
devashishdxt,
calvinaco,
tomtau,
leejw51crypto,
lezzokafka and
yihuang
yihuang
approved these changes
Dec 17, 2019
tomtau
suggested changes
Dec 17, 2019
calvinlauyh
force-pushed
the
feature/cro-654-unused-imports
branch
from
d0a00af to
f9ddf5b
Compare
|
bors try |
calvinlauyh
force-pushed
the
feature/cro-654-unused-imports
branch
from
f9ddf5b to
137f94b
Compare
|
bors try- |
|
bors try |
tryBuild failed |
|
bors retry |
Solution: Terminate on warnings on CI
calvinlauyh
force-pushed
the
feature/cro-654-unused-imports
branch
from
137f94b to
0cde825
Compare
|
bors try- |
|
bors try |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 17, 2019
691: Problem: (CRO-654) Fix unnoticed warnings r=tomtau a=calvinlauco Solution: Add checking to CI pipeline and fix existing warnings Co-authored-by: Calvin Lau <[email protected]>
tryBuild succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Add checking to CI pipeline and fix existing warnings