Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Problem: many unused features and code in merkle trie code dependency #1307

Closed
tomtau opened this issue Mar 26, 2020 · 2 comments
Closed

Problem: many unused features and code in merkle trie code dependency #1307

tomtau opened this issue Mar 26, 2020 · 2 comments
Assignees
@yihuang @devashishdxt
Milestone
CRO Sprint 28

Comments

@tomtau
Copy link
Contributor

tomtau commented Mar 26, 2020 •
edited
Loading

the code could be somewhat simplified if it's cleaned up from things we don't use and make it say only work with "kvdb-*" backend + scale codec + blake3
@tomtau tomtau added this to the CRO Sprint 27 milestone Mar 26, 2020
@tomtau tomtau modified the milestones: CRO Sprint 27, CRO Sprint 28 Apr 9, 2020
@tomtau
Copy link
Contributor Author

tomtau commented Apr 9, 2020

This correspond to the initial cleanup https://github.com/crypto-com/chain/blob/master/architecture-docs/adr-003.md#jellyfish-merkle-tree-codebase

@tomtau
Copy link
Contributor Author

tomtau commented Apr 9, 2020

yihuang added a commit to yihuang/chain that referenced this issue Apr 13, 2020
@yihuang
Problem (Fix crypto-com#1307): many unused features and code in merkl…
b09a1c1 
…e trie code dependency

Solution:
- Cleanup jellyfish library
- Add the integration ground work for jellyfish, step1 of adr-003
yihuang added a commit to yihuang/chain that referenced this issue Apr 13, 2020
@yihuang
Problem (Fix crypto-com#1307): many unused features and code in merkl…
5baac5e 
…e trie code dependency

Solution:
- Cleanup jellyfish library
- Add the integration ground work for jellyfish, step1 of adr-003
yihuang added a commit to yihuang/chain that referenced this issue Apr 13, 2020
@yihuang
Problem (Fix crypto-com#1307): many unused features and code in merkl…
4dddf18 
…e trie code dependency

Solution:
- Cleanup jellyfish library
- Add the integration ground work for jellyfish, step1 of adr-003
yihuang added a commit to yihuang/chain that referenced this issue Apr 14, 2020
@yihuang
Problem (Fix crypto-com#1307): many unused features and code in merkl…
0227198 
…e trie code dependency

Solution:
- Cleanup jellyfish library
- Add the integration ground work for jellyfish, step1 of adr-003
yihuang added a commit to yihuang/chain that referenced this issue Apr 14, 2020
@yihuang
Problem (Fix crypto-com#1307): many unused features and code in merkl…
cda936a 
…e trie code dependency

Solution:
- Cleanup jellyfish library
- Add the integration ground work for jellyfish, step1 of adr-003
yihuang added a commit to yihuang/chain that referenced this issue Apr 14, 2020
@yihuang
Problem (Fix crypto-com#1307): many unused features and code in merkl…
71e0ddb 
…e trie code dependency

Solution:
- Cleanup jellyfish library
- Add the integration ground work for jellyfish, step1 of adr-003
yihuang added a commit to yihuang/chain that referenced this issue Apr 14, 2020
@yihuang
Problem (Fix crypto-com#1307): many unused features and code in merkl…
bdc6b8d 
…e trie code dependency

Solution:
- Cleanup jellyfish library
- Add the integration ground work for jellyfish, step1 of adr-003
bors bot added a commit that referenced this issue Apr 14, 2020
@bors @yihuang
Merge #1424
b528ee5 
1424: Problem (Fix #1307): many unused features and code in merkle trie code dependency r=tomtau a=yihuang

Solution:
- Cleanup jellyfish library
- Add the integration ground work for jellyfish, step1 of adr-003

Co-authored-by: yihuang <[email protected]>
yihuang added a commit to yihuang/chain that referenced this issue Apr 14, 2020
@yihuang
Problem (Fix crypto-com#1307): many unused features and code in merkl…
d004b50 
…e trie code dependency

Solution:
- Cleanup jellyfish library
- Add the integration ground work for jellyfish, step1 of adr-003
bors bot added a commit that referenced this issue Apr 14, 2020
@bors @yihuang
Merge #1424
55d1f1b 
1424: Problem (Fix #1307): many unused features and code in merkle trie code dependency r=tomtau a=yihuang

Solution:
- Cleanup jellyfish library
- Add the integration ground work for jellyfish, step1 of adr-003

Co-authored-by: yihuang <[email protected]>
@bors bors bot closed this as completed in 1641d56 Apr 14, 2020
allthatjazzleo pushed a commit to allthatjazzleo/chain that referenced this issue Apr 22, 2020
@yihuang @allthatjazzleo
Problem (Fix crypto-com#1307): many unused features and code in merkl…
9bae3b7 
…e trie code dependency

Solution:
- Cleanup jellyfish library
- Add the integration ground work for jellyfish, step1 of adr-003
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yihuang yihuang

@devashishdxt devashishdxt

Labels
None yet
Projects
None yet
Milestone
CRO Sprint 28
Development

No branches or pull requests
3 participants
@yihuang @tomtau @devashishdxt