This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem: duplicate storage between chain-abci and tx-validation app #866
Assignees
Milestone
Comments
This was referenced Feb 3, 2020
tomtau
added a commit
to tomtau/chain
that referenced
this issue
Feb 14, 2020
…ixes crypto-com#866) Solution: as a part of ADR-001: https://github.com/crypto-com/chain/blob/master/architecture-docs/adr-001.md - tx-validation-app moved to chain-abci - chain-abci build process expanded to handle SGX SDK steps for C stubs -- on non-Linux systems, it'd display a warning and compile the mock version - tx-validation-app SGX unit test moved to chain-abci under a "sgx-test" feature flag - tx-query-app test removed (it was a kind of "mini-integration" / functionality test that assumed a lot of old behaviour, and all of this is now tested in integration tests) - enclave-bridge takes "intra enclave" requests that are passed directly to the ecalls and returns the response - ZMQ server started in chain-abci in a separate thread to handle tx-query requests (note: tx-query was out of scope of ADR-001, as it doesn't have any storage -- its future is TBD depending on audit feedback etc.) - redundant enclave protocol variants removed - "readonly" storage version provided for serving tx-query requests -- rocksdb/kvdb is thread-safe... zmq server then takes the latest chain state or sealed transactions directly -- note: some fixes related to fees, enclave protocol etc. (other steps of ADR-001) would be addressed in a separate PR - chain-abci storage expanded with one column for sealed transaction payloads - integration test building and environment preparation updated note: Makefile + chain-docs aren't updated yet / would be addressed in separate PRs
tomtau
added a commit
to tomtau/chain
that referenced
this issue
Feb 16, 2020
…ixes crypto-com#866) Solution: as a part of ADR-001: https://github.com/crypto-com/chain/blob/master/architecture-docs/adr-001.md - tx-validation-app moved to chain-abci - chain-abci build process expanded to handle SGX SDK steps for C stubs -- on non-Linux systems, it'd display a warning and compile the mock version - tx-validation-app SGX unit test moved to chain-abci under a "sgx-test" feature flag - tx-query-app test removed (it was a kind of "mini-integration" / functionality test that assumed a lot of old behaviour, and all of this is now tested in integration tests) - enclave-bridge takes "intra enclave" requests that are passed directly to the ecalls and returns the response - ZMQ server started in chain-abci in a separate thread to handle tx-query requests (note: tx-query was out of scope of ADR-001, as it doesn't have any storage -- its future is TBD depending on audit feedback etc.) - redundant enclave protocol variants removed - "readonly" storage version provided for serving tx-query requests -- rocksdb/kvdb is thread-safe... zmq server then takes the latest chain state or sealed transactions directly -- note: some fixes related to fees, enclave protocol etc. (other steps of ADR-001) would be addressed in a separate PR - chain-abci storage expanded with one column for sealed transaction payloads - integration test building and environment preparation updated note: Makefile + chain-docs aren't updated yet / would be addressed in separate PRs
bors bot
added a commit
that referenced
this issue
Feb 16, 2020
1073: Problem: duplicate storage between chain-abci and tx-validation app (fixes #866) r=tomtau a=tomtau Solution: as a part of ADR-001: https://github.com/crypto-com/chain/blob/master/architecture-docs/adr-001.md - tx-validation-app moved to chain-abci - chain-abci build process expanded to handle SGX SDK steps for C stubs -- on non-Linux systems, it'd display a warning and compile the mock version - tx-validation-app SGX unit test moved to chain-abci under a "sgx-test" feature flag - tx-query-app test removed (it was a kind of "mini-integration" / functionality test that assumed a lot of old behaviour, and all of this is now tested in integration tests) - enclave-bridge takes "intra enclave" requests that are passed directly to the ecalls and returns the response - ZMQ server started in chain-abci in a separate thread to handle tx-query requests (note: tx-query was out of scope of ADR-001, as it doesn't have any storage -- its future is TBD depending on audit feedback etc.) - redundant enclave protocol variants removed - "readonly" storage version provided for serving tx-query requests -- rocksdb/kvdb is thread-safe... zmq server then takes the latest chain state or sealed transactions directly -- note: some fixes related to fees, enclave protocol etc. (other steps of ADR-001) would be addressed in a separate PR - chain-abci storage expanded with one column for sealed transaction payloads - integration test building and environment preparation updated note: Makefile + chain-docs aren't updated yet / would be addressed in separate PRs Co-authored-by: Tomas Tauber <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
https://github.com/crypto-com/chain/blob/master/architecture-docs/adr-001.md
#753
The text was updated successfully, but these errors were encountered: