Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Problem (Fix #1296): sgx-cargo-1804-hw1 is not easy to run locally #1298

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Problem (Fix #1296): sgx-cargo-1804-hw1 is not easy to run locally #1298

merged 1 commit into from
Mar 25, 2020

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Mar 25, 2020 •
edited
Loading

Solution:
- Move it into default pipeline

drone exec --trusted --include sgx-test

@codecov
Copy link

codecov bot commented Mar 25, 2020 •
edited
Loading

Codecov Report

Merging #1298 into master will decrease coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #1298     +/-   ##
=========================================
- Coverage   63.85%   63.65%   -0.2%     
=========================================
  Files         151      154      +3     
  Lines       20447    20619    +172     
=========================================
+ Hits        13056    13126     +70     
- Misses       7391     7493    +102
Impacted Files Coverage Δ
client-core/src/signer/key_pair_signer.rs 83.33% <0%> (-10.42%) ⬇️
client-cli/src/main.rs 47.47% <0%> (-3.62%) ⬇️
client-core/src/types/transaction_change.rs 81.09% <0%> (-3.08%) ⬇️
client-core/src/signer/wallet_signer.rs 87.5% <0%> (-1.89%) ⬇️
...action_builder/raw_transfer_transaction_builder.rs 87.4% <0%> (-0.56%) ⬇️
chain-core/src/tx/fee/mod.rs 87% <0%> (-0.5%) ⬇️
client-core/src/service/key_service.rs 93.33% <0%> (-0.29%) ⬇️
client-rpc/src/server.rs 6.25% <0%> (-0.12%) ⬇️
cro-clib/src/transaction.rs 0% <0%> (ø) ⬆️
cro-clib/src/transaction_deposit.rs 0% <0%> (ø) ⬆️
... and 24 more

@tomtau
Copy link
Contributor

tomtau commented Mar 25, 2020

bors try

bors bot added a commit that referenced this pull request Mar 25, 2020
@bors
Try #1298:
5ecb6cf
@yihuang
Problem (Fix crypto-com#1296): sgx-cargo-1804-hw1 is not easy to run …
448e95b 
…locally

Solution:
- Move it into default pipeline
tomtau
tomtau approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 25, 2020

try

Timed out

bors bot added a commit that referenced this pull request Mar 25, 2020
@bors @yihuang
Merge #1292 #1298
2b30647 
1292: Problem (Fix #1142): revised punishment mechanisms not implemented r=tomtau a=yihuang

Solution:
- revised staking and punishment implementation

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/crypto-com/chain/1292)
<!-- Reviewable:end -->


1298: Problem (Fix #1296): sgx-cargo-1804-hw1 is not easy to run locally r=tomtau a=yihuang

Solution:
    - Move it into default pipeline

```
drone exec --trusted --include sgx-test
```

Co-authored-by: yihuang <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 25, 2020

Build failed (retrying...)

@bors
Copy link
Contributor

bors bot commented Mar 25, 2020

Build succeeded

@bors bors bot merged commit 0271ac7 into crypto-com:master Mar 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomtau tomtau tomtau approved these changes

@leejw51crypto leejw51crypto leejw51crypto approved these changes

@calvinaco calvinaco Awaiting requested review from calvinaco calvinaco is a code owner

@devashishdxt devashishdxt Awaiting requested review from devashishdxt devashishdxt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yihuang @tomtau @leejw51crypto