Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Problem: (fix #1272) chain-abci restore_from_storage not unit tested #1513

Merged
merged 1 commit into from
May 1, 2020

Conversation

linfeng-crypto
Copy link
Contributor

solution:
because the function restore_from_storege is private, I added a unit test to test the other function new_with_storage which can cover it.

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #1513 into master will increase coverage by 0.56%.
The diff coverage is 96.66%.

@@            Coverage Diff             @@
##           master    #1513      +/-   ##
==========================================
+ Coverage   65.19%   65.75%   +0.56%     
==========================================
  Files         162      161       -1     
  Lines       21451    21789     +338     
==========================================
+ Hits        13984    14327     +343     
+ Misses       7467     7462       -5     
Impacted Files Coverage Δ
chain-abci/tests/abci_app.rs 94.85% <96.66%> (+0.20%) ⬆️
chain-core/src/state/account/address.rs 68.18% <0.00%> (-20.46%) ⬇️
chain-tx-enclave/mock-utils/src/lib.rs 97.22% <0.00%> (-2.78%) ⬇️
chain-storage/src/jellyfish.rs 88.28% <0.00%> (-2.26%) ⬇️
chain-core/src/state/account.rs 85.47% <0.00%> (-0.43%) ⬇️
chain-core/src/common/merkle_tree.rs 97.81% <0.00%> (-0.22%) ⬇️
client-rpc/src/server.rs 6.08% <0.00%> (-0.17%) ⬇️
cro-clib/src/jsonrpc.rs 0.00% <0.00%> (ø)
client-cli/src/command.rs 0.00% <0.00%> (ø)
client-rpc/src/program.rs 0.00% <0.00%> (ø)
... and 28 more

Copy link
Collaborator

@leejw51crypto leejw51crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or seems codecov isn't precise

@tomtau
Copy link
Contributor

tomtau commented May 1, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented May 1, 2020

Build succeeded:

@bors bors bot merged commit e55aa53 into crypto-com:master May 1, 2020
@linfeng-crypto linfeng-crypto changed the title Problem: (fix #1217) chain-abci restore_from_storage not unit tested Problem: (fix #1272) chain-abci restore_from_storage not unit tested May 5, 2020
@linfeng-crypto linfeng-crypto deleted the issue-1272 branch May 5, 2020 02:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants