This repository has been archived by the owner on Feb 18, 2025. It is now read-only.
Fix missing suffix in fork mode without proxy #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7
When using fork mode with a proxy, there are two implementations, each with a suffix
V1
orV2
, plus a single proxy without a suffix. In path mode there are two proxies as well, with the same suffixes. So when generating the low-level calls, we were first checking whether a proxy was given (to decide which contract variable name to use) and then checking if fork mode is being used (to determine whether to add the suffix to the proxy).However, this did not consider the case where fork mode is used without a proxy. In that case we still have two implementations with suffixes, but since there is no proxy, it doesn't matter whether or not we're using fork mode - we need to include the suffixes anyway.
This was resolved by simply appending
or proxy is None
to the if condition on line 438 of code_generation.py