Skip to content
This repository has been archived by the owner on Feb 18, 2025. It is now read-only.

Fix missing suffix in fork mode without proxy #11

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

webthethird
Copy link
Collaborator

Resolves #7

When using fork mode with a proxy, there are two implementations, each with a suffix V1 or V2, plus a single proxy without a suffix. In path mode there are two proxies as well, with the same suffixes. So when generating the low-level calls, we were first checking whether a proxy was given (to decide which contract variable name to use) and then checking if fork mode is being used (to determine whether to add the suffix to the proxy).

However, this did not consider the case where fork mode is used without a proxy. In that case we still have two implementations with suffixes, but since there is no proxy, it doesn't matter whether or not we're using fork mode - we need to include the suffixes anyway.

This was resolved by simply appending or proxy is None to the if condition on line 438 of code_generation.py

@webthethird webthethird merged commit 66f0334 into dev Jul 20, 2023
@webthethird webthethird deleted the dev-fix-fork-mode-without-proxy branch July 20, 2023 02:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant