This repository has been archived by the owner on Feb 18, 2025. It is now read-only.
Avoid fetching implementation ContractData for the main proxy, since we already have the necessary V1 and V2 ContractData #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds optional
is_main_proxy
andmain_proxy_impl
arguments toget_contract_data_from_address
, and uses them when getting the ContractData for the main proxy given via the-p
argument.Fetching the proxy's implementation ContractData based on the current implementation is helpful for additional targets which are also proxies, but for the main proxy we already have the necessary V1 and V2 ContractData. Fetching the current implementation's data only adds more overhead to the static analysis, and in cases like the malicious Ankr upgrade, trying to fetch the current implementation on chain causes Hybrid Mode to fail, since the current implementation is still unverified.
Tl;dr: now we can run: