default stderr if not provided to Cli ctor #2138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
In
Cli
, default thestderr
property of the constructor object toprocess.stderr
if it's not defined - making the property effectively optional for consumers.⚡️ What's your motivation?
We introduced this property in #2137 which was effectively a breaking change for people who use the
Cli
class for framework integrations. It managed to fly under the radar until https://github.com/cucumber/cucumber-js/pull/2092/files#diff-7f71b0d311e14868f853f726912b222ac5e2aee58d985f1758d6b8f5e19c4c5c (8.5.2) where there'll be an error if it's missing. This affectsnightwatch
for example (see #2137).This class will shortly be deprecated in favour of
runCucumber
et al, but in the meantime it should be stable.🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.