[Core] Include DefaultObjectFactory as part of the API #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
force-pushed
the
include-default-object-factory-in-api
branch
from
5824afd to
ec4eb64
Compare
Cucumber can be used with different ObjectFactory implementations. When multiple implementations are available the `cucumber.object-factory` property allows Cucumber to disambiguate between the preferred choice. Because the `DefaultObjectFactory` was not actually loaded via SPI it was not possible to explicitly select the default implementation. By using `cucumber.object-factory=io.cucumber.core.backend.DefaultObjectFactory` users can now select the `DefaultObjectFactory` implementation. This may benefit users who use Cucumber in both unit and integration tests. Some object factory implementations such as Cucumber Spring are slow to startup using the `DefaultObjectFactory` would allow the suite of unit tests to be executed faster.
mpkorstanje
force-pushed
the
include-default-object-factory-in-api
branch
from
ec4eb64 to
273aecb
Compare
Codecov Report
@@ Coverage Diff @@
## main #2400 +/- ##
============================================
+ Coverage 83.53% 83.61% +0.07%
- Complexity 2623 2634 +11
============================================
Files 316 317 +1
Lines 9306 9312 +6
Branches 902 905 +3
============================================
+ Hits 7774 7786 +12
+ Misses 1197 1191 -6
Partials 335 335
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cucumber can be used with different ObjectFactory implementations. When
multiple implementations are available the
cucumber.object-factorypropertyallows Cucumber to disambiguate between the preferred choice.
Because the
DefaultObjectFactorywas not actually loaded via SPI it was notpossible to explicitly select the default implementation. By using
cucumber.object-factory=io.cucumber.core.backend.DefaultObjectFactoryusers can now select the
DefaultObjectFactoryimplementation.This may benefit users who use Cucumber in both unit and integration tests.
Some object factory implementations such as Cucumber Spring are slow to startup
using the
DefaultObjectFactorywould allow the suite of unit tests to beexecuted faster.