fix(cpp): Actually use the VERSION file #376
Open
+22
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to what cucumber#328 added to the C library, actually use the `VERSION` file to set the project version for the C++ library, and use the resulting project version to set the shared library version and ABi version (CMake `SOVERSION`). Fixes cucumber#375.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
PR #328 did not end up using the
VERSIONfile for C++ project versioning or for C++ shared-library versioning or ABI/SONAMEversioning, even though I think that’s what was desired, c.f. #328 (comment).This PR imitates the version/
SOVERSIONhandling that was added to the C library in the C++ library.⚡️ What's your motivation?
Fixes #375
🏷️ What kind of change is this?
(This is breaking only in that it affects the version number and
SONAMEversion / ABI version of the C++ library. It does not affect the API.)♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.