Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] refactor: Update rubocop and introduce to CI #254

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/test-ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,16 @@ on:
workflow_call:

jobs:
rubocop:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: '3.0'
bundler-cache: true
- run: bundle exec rubocop

test-ruby:
runs-on: ${{ matrix.os }}
strategy:
Expand All @@ -22,7 +32,6 @@ jobs:
include:
- os: macos-latest
ruby: '3.3'

steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
Expand Down
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Fixed
- [Dotnet] Fixed code generation for types that accept List<T> as parameters. Constructors were not properly handling null input. ([#249](https://github.com/cucumber/messages/pull/249) [clrudolphi])
- [Dotnet] Fixed code generation for types that accept List<T> as parameters. Constructors were not properly handling null input. ([#249](https://github.com/cucumber/messages/pull/249) [clrudolphi](https://github.com/clrudolphi))

### Changed
- [Go] Switch to Google's UUID module ([#251](https://github.com/cucumber/messages/pull/251))
- [Ruby] Updated the rubocop dependencies to use latest cops & run rubocop in pipeline

## [26.0.0] - 2024-08-15
### Added
Expand Down
3 changes: 3 additions & 0 deletions ruby/.rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ AllCops:
TargetRubyVersion: 3.0
NewCops: enable

Gemspec/DevelopmentDependencies:
Enabled: false

Gemspec/RequireMFA:
Enabled: false

Expand Down
12 changes: 6 additions & 6 deletions ruby/cucumber-messages.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ version = File.read(File.expand_path('VERSION', __dir__)).strip
Gem::Specification.new do |s|
s.name = 'cucumber-messages'
s.version = version
s.authors = ['Aslak Hellesøy']
s.authors = ['Aslak Hellesøy', 'Luke Hill']
s.description = "JSON schema-based messages for Cucumber's inter-process communication"
s.summary = "cucumber-messages-#{s.version}"
s.email = '[email protected]'
Expand All @@ -23,13 +23,13 @@ Gem::Specification.new do |s|
'source_code_uri' => 'https://github.com/cucumber/messages'
}

s.add_development_dependency 'cucumber-compatibility-kit', '~> 15.0'
s.add_development_dependency 'rake', '~> 13.1'
s.add_development_dependency 'cucumber-compatibility-kit', '~> 16.2'
s.add_development_dependency 'rake', '~> 13.2'
s.add_development_dependency 'rspec', '~> 3.13'
s.add_development_dependency 'rubocop', '~> 1.50.2'
s.add_development_dependency 'rubocop-performance', '~> 1.21.0'
s.add_development_dependency 'rubocop', '~> 1.66.1'
s.add_development_dependency 'rubocop-performance', '~> 1.22.0'
s.add_development_dependency 'rubocop-rake', '~> 0.6.0'
s.add_development_dependency 'rubocop-rspec', '~> 2.25.0'
s.add_development_dependency 'rubocop-rspec', '~> 3.0.5'

s.files = Dir['README.md', 'LICENSE', 'VERSION', 'lib/**/*']
s.rdoc_options = ['--charset=UTF-8']
Expand Down
2 changes: 1 addition & 1 deletion ruby/spec/cucumber/messages/acceptance_spec.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# frozen_string_literal: true

require 'json'
require 'cucumber-compatibility-kit'
require 'cck/examples'

module Cucumber
module Messages
Expand Down