Support cpp/deps.txt #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our cpp projects use deps.txt to list and download their dependencies. These should be automatically updated. This is especially important because floating dependencies may break the build when we don't expect it to. E.g: cucumber/gherkin#206
|
@chybz and @ursfassler I've gone ahead and merged this. If this isn't how things are supposed to work with CPP, please let me know. I do reckon this will work for:
And I'm happy to refine that further for the other CPP projects. |
|
@mpkorstanje and @ursfassler Thanks. That's my current "solution" on how to fix/improve dependency handling on C++. While specific to these two projects (for now), it's only used in when generating CMakeLists.txt files using |
|
Alright no problem. If you come up with something better, please just ping me and I'll have a look to see how we can update the dependencies automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Our cpp projects use deps.txt to list and download their dependencies. These should be automatically updated.
This is especially important because floating dependencies may break the build when we don't expect it to. E.g: cucumber/gherkin#206
🏷️ What kind of change is this?