This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Cudos 842: Extend gas fees handling #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holymir
reviewed
Jun 29, 2022
maptuhec
suggested changes
Jun 30, 2022
| } | ||
| return gasFee | ||
| if (gasLimit === GAS_AUTO) { | ||
| return gasMultiplier === GAS_AUTO ? GAS_AUTO : gasMultiplier |
There was a problem hiding this comment.
can you skip this if statement and put it in row 19? I thinkg that this whole logic could be made simpler
maptuhec
suggested changes
Jun 30, 2022
| const signer = await SigningCosmWasmClient.connectWithSigner(nodeUrl, wallet) | ||
| // gasPrice in signing client is considered only when auto gas is used | ||
| const signer = await SigningCosmWasmClient.connectWithSigner( | ||
| nodeUrl, wallet, { gasPrice: GasPrice.fromString(getGasPrice()) }) |
There was a problem hiding this comment.
didn't we discuss to remove the gas price from the signer?
There was a problem hiding this comment.
The cosmwasm lib requires the signing client to have gas price when auto gas is used (and actually reads it from there to make its calculations)
maptuhec
approved these changes
Jul 8, 2022
Holymir
approved these changes
Jul 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other fixes:
pachage-jock.jsonas they are not used