chore: refactor in-app queue classes #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
mrehan27
force-pushed
the
rehan/mbl-480-gist-queue-stack-7
branch
from
266122d to
37f042f
Compare
This was referenced Sep 3, 2024
Shahroz16
requested changes
Sep 4, 2024
Shahroz16
reviewed
Sep 4, 2024
mrehan27
force-pushed
the
rehan/mbl-480-gist-delegate-stack-6
branch
from
7808f2a to
4e398a6
Compare
Base automatically changed from
rehan/mbl-480-gist-delegate-stack-6
to
feature/inapp-state-refactor
September 4, 2024 11:07
mrehan27
force-pushed
the
rehan/mbl-480-gist-queue-stack-7
branch
from
37f042f to
dcef79d
Compare
Shahroz16
approved these changes
Sep 4, 2024
| subscribeToInAppMessageState() | ||
| } | ||
|
|
||
| func subscribeToInAppMessageState() { |
There was a problem hiding this comment.
can this method simplified? i understand whats happening here, but looks very messy.
| private var isMessageEmbed: Bool = false | ||
| private var messagePosition: MessagePosition = .center | ||
|
|
||
| private var inAppMessageStoreSubscriber: InAppMessageStoreSubscriber? |
There was a problem hiding this comment.
instead of store, can we keep a strong reference of the subscription? would that resolve the need to keep strong reference?
private var subscription: Task<Void, Never>?
Comment on lines
53
to
74
| func subscribeToInAppMessageState() { | ||
| inAppMessageStoreSubscriber = InAppMessageStoreSubscriber { [self] state in | ||
| switch state.currentMessageState { | ||
| case .displayed: | ||
| threadUtil.runMain { | ||
| self.loadModalMessage() | ||
| } | ||
|
|
||
| case .dismissed: | ||
| threadUtil.runMain { | ||
| self.engine.delegate = nil | ||
| self.dismissMessage() | ||
| self.inAppMessageStoreSubscriber = nil | ||
| } | ||
|
|
||
| default: | ||
| break | ||
| } | ||
| } | ||
| if let subscriber = inAppMessageStoreSubscriber { | ||
| inAppMessageManager.subscribe(keyPath: \.currentMessageState, subscriber: subscriber) | ||
| } |
There was a problem hiding this comment.
Suggested change
| func subscribeToInAppMessageState() { | |
| inAppMessageStoreSubscriber = InAppMessageStoreSubscriber { [self] state in | |
| switch state.currentMessageState { | |
| case .displayed: | |
| threadUtil.runMain { | |
| self.loadModalMessage() | |
| } | |
| case .dismissed: | |
| threadUtil.runMain { | |
| self.engine.delegate = nil | |
| self.dismissMessage() | |
| self.inAppMessageStoreSubscriber = nil | |
| } | |
| default: | |
| break | |
| } | |
| } | |
| if let subscriber = inAppMessageStoreSubscriber { | |
| inAppMessageManager.subscribe(keyPath: \.currentMessageState, subscriber: subscriber) | |
| } | |
| func subscribeToInAppMessagdeState() { | |
| let subscriber = InAppMessageStoreSubscriber { [self] state in | |
| switch state.currentMessageState { | |
| case .displayed: | |
| self.threadUtil.runMain { | |
| self.loadModalMessage() | |
| } | |
| case .dismissed: | |
| self.threadUtil.runMain { | |
| self.engine.delegate = nil | |
| self.dismissMessage() | |
| self.subscription = nil | |
| } | |
| default: | |
| break | |
| } | |
| } | |
| subscription = inAppMessageManager.subscribe(keyPath: \.currentMessageState, subscriber: subscriber) | |
| } |
if keeping the reference of subscription works.
There was a problem hiding this comment.
Discussed on call, we'll merge this for now and think later more on this later
| if let modalViewManager = modalViewManager { | ||
| modalViewManager.dismissModalView { [weak self] in | ||
| guard let self = self else { return } | ||
| self.delegate?.messageDismissed(message: self.currentMessage) | ||
| guard let _ = self else { return } |
There was a problem hiding this comment.
we are not using self, is there any benefit of this?
There was a problem hiding this comment.
Discussed on call, will be merging this as it looks okay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of MBL-480
closes MBL-487
Changes
Gist,MessageManager, andQueueManagerclasses to use the newly added state and managerGist,MessageManager, andQueueManagertoDiGraph