Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud support for PCD files and related images #6059

Closed
wants to merge 5 commits into from

Conversation

malloc404
Copy link

Motivation and context

I noticed thru testing different ways of creating a task with 3D data that it seemed to not be supported yet, and I needed these features for my work asap. I did try to keep the changes generalized and simple, as to not modify too much of the code, but some bits may be more "hacky" than others. These changes address #5954

The intended workflow this change brings is:

  • A user stores PCD files and any related images to them on the cloud in one of the supported data formats along with a manifest.jsonl file
  • When creating a task in the CVAT UI, the user selects the .pcd files to use.
    • Originally tried with a .zip file, but since the data in the zip is not available at the time of task creation when the file is in cloud storage, it seemed like it would be a pain to manage. Plus in our use case, it removes the step of creating and storing a zip file of the data on the cloud.
  • Once task is created, opening the task will load in the PCD data and the related images that are stored on the cloud.

Example cloud manifest.jsonl file:

{"version":"1.1"}
{"type":"images"}
{"name":"pointcloud/points","extension":".pcd","width":123456,"height":1,"meta":{"related_images":["related_images/points_pcd/context_image_1.jpg","related_images/points_pcd/context_image_2.jpg"]}}

Example output:
Screenshot from 2023-04-21 10-13-19

How has this been tested?

AWS S3 buckets were used for cloud storage. After getting PCD and related image data working with these changes, I manually tested that creating tasks would work with:

  • 2D images stored on the cloud
  • 2D images stored with connected file share
  • 3D zip from connected file share

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

marissa added 4 commits April 21, 2023 09:42
PCD files are now supported with these changes
If using cloud storage, these changes support PCD files and any related
images to them being used to create a new task
Modified existing function for preparing a chunk buffer to handle
downloading related images from cloud storage
@malloc404 malloc404 changed the title Cloud support for PCD files and related image Cloud support for PCD files and related images Apr 21, 2023
@nmanovic
Copy link
Contributor

@malloc404 , thanks for the contribution! Could you please resolve conflicts?

@malloc404
Copy link
Author

@nmanovic fixed the conflicts, though I didn't have time to test the new changes. Can this be looked at sometime soon so that no new merge conflicts arise?

@bsekachev
Copy link
Member

Currently the pull request outdated, I will close it.

@bsekachev bsekachev closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants