Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failures #4

Closed
cyli opened this issue Aug 25, 2015 · 4 comments
Closed

Fix test failures #4

cyli opened this issue Aug 25, 2015 · 4 comments

Comments

@cyli
Copy link
Owner

cyli commented Aug 25, 2015

Not sure why, but the previous master passed all tests, and #3 also passed all tests, but master after merging #3 is failing all the tests.
@cyli
Copy link
Owner Author

cyli commented Sep 6, 2015

Tried a different version of jruby, in case it's the 9.x versions causing issues: https://travis-ci.org/cyli/logstash-output-slack/jobs/78963265

Still a failure.

@cyli
Copy link
Owner Author

cyli commented Sep 6, 2015

Ok, using rbenv locally, installed jruby-1.7.21 (same as https://travis-ci.org/cyli/logstash-output-slack/jobs/78963265).

  • bundle install
  • bundle exec rspec spec - no failures :|

Locally running JDK6. Attempted building this in a docker container running JDK7 + jruby 1.7.22, and that still all passed.

@cyli
Copy link
Owner Author

cyli commented Sep 6, 2015

Would appreciate help from someone who actually knows ruby! :D (I do not)

@cyli
Copy link
Owner Author

cyli commented Sep 6, 2015

Ok, looks like the issue is that in the newer version of logstash, values for the add_fields hash must be a string? 3eba58e fixed the issue.

@cyli cyli closed this as completed Sep 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cyli