Fix error interpolation on malformed requests #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes traces like this, if you, say, omit the '#' in your channel name:
root@f986c8becbda:~# /opt/logstash/bin/logstash -e '
input { stdin {} }
output { slack { username => "loggy" icon_emoji => ":evergreen_tree:"
format => "%{message}" channel => "signups" url =>
"your-slack-URL"
} }'
slack plugin is using the 'milestone' method to declare the version of
the plugin this method is deprecated in favor of declaring the version
inside the gemspec. {:level=>:warn}
Logstash startup completed
Testing testing 1 2 3
Unhandled exception {:exception=>#<TypeError: can't convert
Net::HTTPInternalServerError into String>,
:stacktrace=>["org/jruby/RubyString.java:1157:in `+'",
"/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-output-slack-0.1.0/lib/logstash/outputs/slack.rb:69:in
`receive'", "org/jruby/RubyProc.java:271:in `call'",
"/opt/logstash/vendor/bundle/jruby/1.9/gems/rest-client-1.8.0/lib/restclient/request.rb:493:in
`process_result'",
"/opt/logstash/vendor/bundle/jruby/1.9/gems/rest-client-1.8.0/lib/restclient/request.rb:421:in
`transmit'", "/opt/logstash/vendor/jruby/lib/ruby/1.9/net/http.rb:746:in
`start'",
"/opt/logstash/vendor/bundle/jruby/1.9/gems/rest-client-1.8.0/lib/restclient/request.rb:413:in
`transmit'",
"/opt/logstash/vendor/bundle/jruby/1.9/gems/rest-client-1.8.0/lib/restclient/request.rb:176:in
`execute'",
"/opt/logstash/vendor/bundle/jruby/1.9/gems/rest-client-1.8.0/lib/restclient/request.rb:41:in
`execute'",
"/opt/logstash/vendor/bundle/jruby/1.9/gems/rest-client-1.8.0/lib/restclient.rb:69:in
`post'",
"/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-output-slack-0.1.0/lib/logstash/outputs/slack.rb:64:in
`receive'",
"/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-1.5.0-java/lib/logstash/outputs/base.rb:88:in
`handle'", "(eval):22:in `output_func'",
"/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-1.5.0-java/lib/logstash/pipeline.rb:244:in
`outputworker'",
"/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-1.5.0-java/lib/logstash/pipeline.rb:166:in
`start_outputs'"], :level=>:warn}
|
Oops, I'm sorry, I'm not sure why I missed this PR. This is great, thank you for your contribution! |
cyli
added a commit
that referenced
this pull request
Aug 10, 2015
Fix error interpolation on malformed requests
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes traces like this, if you, say, omit the '#' in your channel name:
root@f986c8becbda:~# /opt/logstash/bin/logstash -e '
input { stdin {} }
output { slack { username => "loggy" icon_emoji => ":evergreen_tree:"
format => "%{message}" channel => "signups" url =>
"your-slack-URL"
} }'
slack plugin is using the 'milestone' method to declare the version of
the plugin this method is deprecated in favor of declaring the version
inside the gemspec. {:level=>:warn}
Logstash startup completed
Testing testing 1 2 3
Unhandled exception {:exception=>#<TypeError: can't convert
Net::HTTPInternalServerError into String>,
:stacktrace=>["org/jruby/RubyString.java:1157:in
+'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-output-slack-0.1.0/lib/logstash/outputs/slack.rb:69:inreceive'", "org/jruby/RubyProc.java:271:incall'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/rest-client-1.8.0/lib/restclient/request.rb:493:inprocess_result'","/opt/logstash/vendor/bundle/jruby/1.9/gems/rest-client-1.8.0/lib/restclient/request.rb:421:in
transmit'", "/opt/logstash/vendor/jruby/lib/ruby/1.9/net/http.rb:746:instart'","/opt/logstash/vendor/bundle/jruby/1.9/gems/rest-client-1.8.0/lib/restclient/request.rb:413:in
transmit'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/rest-client-1.8.0/lib/restclient/request.rb:176:inexecute'","/opt/logstash/vendor/bundle/jruby/1.9/gems/rest-client-1.8.0/lib/restclient/request.rb:41:in
execute'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/rest-client-1.8.0/lib/restclient.rb:69:inpost'","/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-output-slack-0.1.0/lib/logstash/outputs/slack.rb:64:in
receive'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-1.5.0-java/lib/logstash/outputs/base.rb:88:inhandle'", "(eval):22:inoutput_func'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-1.5.0-java/lib/logstash/pipeline.rb:244:inoutputworker'","/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-1.5.0-java/lib/logstash/pipeline.rb:166:in
`start_outputs'"], :level=>:warn}