Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add skip domain injection description #25463

Merged
merged 2 commits into from
Jan 13, 2023
Merged

fix: add skip domain injection description #25463

merged 2 commits into from
Jan 13, 2023

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Jan 13, 2023 •
edited
Loading

  • Closes N/A

User facing changelog

Adds locales for experimentalSkipDomainInjection

Before

After

Additional details

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@AtofStryker AtofStryker changed the title Fix/add skip domain injection desc fix: add skip domain injection description Jan 13, 2023
@cypress
Copy link

cypress bot commented Jan 13, 2023 •
edited
Loading


Test summary

5235 • 0 • 98 • 0 • Flakiness 9

Run details
Project cypress
Status Passed
Commit fe0869c
Started Jan 13, 2023 9:15 PM
Ended Jan 13, 2023 9:29 PM
Duration 13:43 💡
OS Linux Debian -
Browser Multiple

View run in Cypress Dashboard ➡️

Flakiness

migration.cy.ts 1 Flakiness
1 Full migration flow for each project > completes journey for migration-e2e-custom-test-files
e2e/origin/cookie_behavior.cy.ts 4 Flakiness
1 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
2 ... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
3 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
4 ... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
This comment includes only the first 5 flaky tests. See all 9 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@AtofStryker AtofStryker force-pushed the fix/addSkipDomainInjectionDesc branch from 7411a77 to 67dbfbc Compare January 13, 2023 20:35
@AtofStryker AtofStryker force-pushed the fix/addSkipDomainInjectionDesc branch from 67dbfbc to fe0869c Compare January 13, 2023 20:38
@AtofStryker AtofStryker requested a review from mschile January 13, 2023 20:39
@AtofStryker AtofStryker merged commit 0d48199 into develop Jan 13, 2023
@AtofStryker AtofStryker deleted the fix/addSkipDomainInjectionDesc branch January 13, 2023 21:52
tgriesser added a commit that referenced this pull request Jan 18, 2023
@tgriesser
Merge branch 'develop' into tgriesser/spike/spike
3e305cd 
* develop: (45 commits)
  fix: re-enable CYPRESS_INTERNAL_VITE_DEV development (#25364)
  fix: add skip domain injection description (#25463)
  fix: revert CSP header and script-src addition (#25445)
  chore: Update v8 snapshot cache (#25401)
  feat: Do not strip CSP headers from HTTPResponse (#24760)
  fix: keep spaces in formatted output in test runner (#24687)
  fix: Restrict dependency versions to known supported ranges (#25380)
  chore: Update v8 snapshot cache (#25370)
  feat: experimental skip domain injection (#25307)
  chore: support vite v4 for component testing (#25365)
  feat: Use JSX/TSX in generated spec filenames (#25318)
  docs(angular): Properties that are spied upon have to be defined within `componentProperties` instead of on root level. (#25359)
  chore: remove lint-changed from scripts/docs (#25308)
  chore: bump to 12.3.0 [skip ci] (#25355)
  fix: make NODE_ENV "production" for prod builds of launchpad (#25320)
  fix: .contains() should only return one element at all times (#25250)
  feat: add currentRetry to Cypress API (#25297)
  chore: release @cypress/webpack-dev-server-v3.2.2
  chore: release create-cypress-tests-v2.0.1
  fix: change wording for spec creation (#25271)
  ...
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 24, 2023

Released in 12.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.4.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jan 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mjhenkes mjhenkes mjhenkes approved these changes

@mschile mschile mschile approved these changes

@emilyrohrbough emilyrohrbough emilyrohrbough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AtofStryker @mjhenkes @mschile @emilyrohrbough