Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: attempt to not cache electron build #30446

Merged
merged 5 commits into from
Oct 23, 2024
Merged

chore: attempt to not cache electron build #30446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
30f68a2
chore: attempt to not cache electron build
ryanthemanuel Oct 23, 2024
7a0c066
blank -- run ci
ryanthemanuel Oct 23, 2024
d37ea7e
fix -- run ci
ryanthemanuel Oct 23, 2024
ea14670
fix -- run ci
ryanthemanuel Oct 23, 2024
7e635e7
improvement
ryanthemanuel Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions nx.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@
},
"namedInputs": {
"sharedGlobals": [
"{workspaceRoot}/scripts",
"{workspaceRoot}/.circleci/cache-version.txt"
"{workspaceRoot}/scripts"
],
"default": [
"{projectRoot}/**/*",
"sharedGlobals"
"sharedGlobals",
"{workspaceRoot}/.circleci/cache-version.txt"
],
"production": [
"default",
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"binary-smoke-test": "node ./scripts/binary.js smoke",
"binary-upload": "node ./scripts/binary.js upload",
"binary-zip": "node ./scripts/binary.js zip",
"build": "lerna run build --stream && lerna run build-cli --stream",
"build": "lerna run build --stream && yarn workspace @packages/electron build-binary && lerna run build-cli --stream",
"build-prod": "lerna run build-prod --stream && node ./cli/scripts/post-build.js && lerna run build-prod --stream --scope",
"build-v8-snapshot-dev": "node --max-old-space-size=8192 tooling/v8-snapshot/scripts/setup-v8-snapshot-in-cypress.js --env=dev",
"build-v8-snapshot-prod": "node --max-old-space-size=8192 tooling/v8-snapshot/scripts/setup-v8-snapshot-in-cypress.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/electron/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"private": true,
"main": "index.js",
"scripts": {
"build": "node ./bin/cypress-electron --install",
"build-binary": "node ./bin/cypress-electron --install",
"clean-deps": "rimraf node_modules",
"postinstall": "echo '@packages/electron needs: yarn build'",
"lint": "eslint --ext .js,.jsx,.ts,.tsx,.json, .",
Expand Down
Loading