-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set up sharing of react via module federation in studio #31129
Open
ryanthemanuel
wants to merge
4
commits into
develop
Choose a base branch
from
ryanm/chore/share-react-in-studio
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
Project |
cypress
|
Branch Review |
ryanm/chore/share-react-in-studio
|
Run status |
|
Run duration | 18m 01s |
Commit |
|
Committer | Ryan Manuel |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
7
|
|
1099
|
|
0
|
|
26543
|
View all changes introduced in this branch ↗︎ |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
46.42%
|
|
---|---|
|
182
|
|
162
|
Accessibility
92.55%
|
|
---|---|
|
3 critical
8 serious
2 moderate
2 minor
|
|
879
|
AtofStryker
reviewed
Feb 21, 2025
mschile
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This PR sets up sharing between the module federation loaded studio code.
In order to have a better avenue to test this, I added a very simple panel that shows up:
CYPRESS_LOCAL_STUDIO_PATH
orCYPRESS_ENABLE_CLOUD_STUDIO
is set and the studio code has been loaded correctlyThe panel loads the React component that is exposed by the studio code in the cloud (which right now is just a div that contains the text "Studio Panel"
I added a few sanity check tests for this panel, but will wait to have a full test suite until we get to this issue
Steps to test
Along with this PR, you can run the development steps. You should be able to see this when entering Studio:
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?