Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set up sharing of react via module federation in studio #31129

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

ryanthemanuel
Copy link
Collaborator

@ryanthemanuel ryanthemanuel commented Feb 18, 2025

Additional details

This PR sets up sharing between the module federation loaded studio code.

In order to have a better avenue to test this, I added a very simple panel that shows up:

  • When CYPRESS_LOCAL_STUDIO_PATH or CYPRESS_ENABLE_CLOUD_STUDIO is set and the studio code has been loaded correctly
  • When studio mode is entered

The panel loads the React component that is exposed by the studio code in the cloud (which right now is just a div that contains the text "Studio Panel"

I added a few sanity check tests for this panel, but will wait to have a full test suite until we get to this issue

Steps to test

Along with this PR, you can run the development steps. You should be able to see this when entering Studio:

image

How has the user experience changed?

PR Tasks

Copy link

cypress bot commented Feb 18, 2025

cypress    Run #60554

Run Properties:  status check passed Passed #60554  •  git commit 9d55e6e8a6: Merge branch 'develop' into ryanm/chore/share-react-in-studio
Project cypress
Branch Review ryanm/chore/share-react-in-studio
Run status status check passed Passed #60554
Run duration 18m 01s
Commit git commit 9d55e6e8a6: Merge branch 'develop' into ryanm/chore/share-react-in-studio
Committer Ryan Manuel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 7
Tests that did not run due to a developer annotating a test with .skip  Pending 1099
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 26543
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  46.42%
  Untested elements 182  
  Tested elements 162  
Accessibility  92.55%
  Failed rules  3 critical   8 serious   2 moderate   2 minor
  Failed elements 879  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants