Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ability to load types from the studio bundle #31153

Open
wants to merge 4 commits into
base: ryanm/chore/share-react-in-studio
Choose a base branch
from

Conversation

ryanthemanuel
Copy link
Collaborator

@ryanthemanuel ryanthemanuel commented Feb 21, 2025

Additional details

This PR sets up a script to download types from the studio bundle and incorporate them into the appropriate places so that they can be used for type validation on the frontend and backend.

Steps to test

Corresponding PR: https://github.com/cypress-io/cypress-services/pull/10258

To run this, you can:

  • Clone the cypress-services repo
    • Run yarn
    • Run yarn watch in app/studio
  • Set CYPRESS_LOCAL_STUDIO_PATH to the path to the cypress-services/app/studio/dist/development directory
    • Clone the cypress repo
      • Run yarn
      • Run yarn gulp downloadStudioTypes

Ensure that the script succeeds.

How has the user experience changed?

PR Tasks

@ryanthemanuel ryanthemanuel self-assigned this Feb 21, 2025
@ryanthemanuel ryanthemanuel changed the title chore: set up sharing of react via module federation in studio chore: add ability to load types from the studio bundle Feb 21, 2025
Copy link

cypress bot commented Feb 21, 2025

cypress    Run #60548

Run Properties:  status check passed Passed #60548  •  git commit 80f921cab8: fix build
Project cypress
Branch Review ryanm/chore/studio-types
Run status status check passed Passed #60548
Run duration 18m 16s
Commit git commit 80f921cab8: fix build
Committer Ryan Manuel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 8
Tests that did not run due to a developer annotating a test with .skip  Pending 1099
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 26543
View all changes introduced in this branch ↗︎
UI Coverage  45.43%
  Untested elements 192  
  Tested elements 164  
Accessibility  92.55%
  Failed rules  3 critical   8 serious   2 moderate   2 minor
  Failed elements 888  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant