-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update python versions - 3.7 deprecation, 3.10 and 3.11 testing support #287
Conversation
Codecov Report
@@ Coverage Diff @@
## master #287 +/- ##
=======================================
Coverage 95.12% 95.12%
=======================================
Files 57 57
Lines 3057 3057
=======================================
Hits 2908 2908
Misses 149 149
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes! Generally I thought your changes looked good. I did have questions regarding the additional files / thoughts below and wanted to get your input. Thanks in advance!
- Would it make sense to update the Python version in
.readthedocs.yml
? - I think we might be able to bump the version of pre-commit in
requirements-dev.yml
to v3.x.x as per comments in Drop support for Python 3.7; Potentially add support for Python 3.10 & Python 3.11 #273 (there are also other steps @kenibrewer mentions which may need attention regarding the devcontainer files). - Should we set a reminder or create a new issue for Python 3.8 EoL (October 2024 sometime)?
Yep, I will add
Thanks for pointing to this issue! I missed this. Will review and make corresponding changes here.
I think this is optional. |
Thanks for the review @d33bs ! This is ready for another round |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comments @gwaybio - LGTM!
Description
With python 3.7 security end of life in 2 weeks, this update is required prior to version 1 release. This also addresses #259.
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.