Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python versions - 3.7 deprecation, 3.10 and 3.11 testing support #287

Merged
merged 8 commits into from
Jun 11, 2023

Conversation

gwaybio
Copy link
Member

@gwaybio gwaybio commented Jun 8, 2023

Description

With python 3.7 security end of life in 2 weeks, this update is required prior to version 1 release. This also addresses #259.

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2023

Codecov Report

Merging #287 (6168197) into master (77d93a3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #287   +/-   ##
=======================================
  Coverage   95.12%   95.12%           
=======================================
  Files          57       57           
  Lines        3057     3057           
=======================================
  Hits         2908     2908           
  Misses        149      149           
Flag Coverage Δ
unittests 95.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gwaybio gwaybio requested a review from d33bs June 8, 2023 18:28
@gwaybio gwaybio mentioned this pull request Jun 10, 2023
12 tasks
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes! Generally I thought your changes looked good. I did have questions regarding the additional files / thoughts below and wanted to get your input. Thanks in advance!

@gwaybio
Copy link
Member Author

gwaybio commented Jun 10, 2023

Would it make sense to update the Python version in .readthedocs.yml?

Yep, I will add

I think we might be able to bump the version of pre-commit in requirements-dev.yml to v3.x.x as per comments in
#273 (there are also other steps @kenibrewer mentions which may need attention regarding the devcontainer files).

Thanks for pointing to this issue! I missed this. Will review and make corresponding changes here.

Should we set a reminder or create a new issue for Python 3.8 EoL (October 2024 sometime)?

I think this is optional.

@gwaybio gwaybio requested a review from d33bs June 11, 2023 12:19
@gwaybio
Copy link
Member Author

gwaybio commented Jun 11, 2023

Thanks for the review @d33bs ! This is ready for another round

Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments @gwaybio - LGTM!

@gwaybio gwaybio merged commit 857fde4 into cytomining:master Jun 11, 2023
@gwaybio gwaybio deleted the python-versions branch June 11, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants