UI tweak on Merge Network Dialog #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for voluble-rugelach-5a3809 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
d2fong
reviewed
Feb 10, 2025
Updates:
|
keiono
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: CW-415
Changes Made
There are lots of code format clean in this PR, please see changes by commit by commit for review more conveniently.
Disable Merge Button when only one network selected and checkbox unselected: Commit
In Cytoscape Desktop, if the checkbox of “Enable merging nodes/edges in the same network” is NOT checked, then merge only one network is not allowed. To be consistent with Cytoscape Desktop, the same behavior is applied here. And the checkboxes are moved to the top to cause users' attention.
Add warning icon and tooltip for node duplication: Commit
In the Merge Network Dialog, if the network is selected as ready for merge, and the nodes in that network have identical values under the 'Matching.Attribute'. Then there would be a warning icon added after the network name.