Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve actions #865

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Improve actions #865

merged 4 commits into from
Nov 8, 2024

Conversation

FH-Inway
Copy link
Member

@FH-Inway FH-Inway commented Oct 3, 2024 •
edited
Loading

This pull request includes several infrastructure changes:

  1. To make analysis of issues like 🐛 ParameterBindingArgumentTransformationException for Invoke-PSMDTemplate > [PSFramework.Serialization.ClixmlSerializer]::FromByteCompressed PowershellFrameworkCollective/psframework#645 easier in the future, the information about what modules and versions are used in an action run are now logged - ba66eeb
  2. The first change in update-generated-text.yml fixes an issue with the cache key for the PowerShell modules - a5bbd6f
  3. The second change in update-generated-text.yml is to create a unique branch name for each pull request. This ensures that fixes for one pull request are not overwritten by fixes for another pull request - 8eaee90
  4. Other changes in the action .yml files are updates of actions to their latest version and recommended usage. - 273cb1f

The pull request was originally created to address PowershellFrameworkCollective/psframework#645 . The issue has been resolved since then. But the improvements that were made as part of the issue mitigation are still valid. The pull request should also be merged to clear the caches of the actions so the latest versions of PSFramework and PSModuleDevelopment are being used.

@FH-Inway FH-Inway marked this pull request as draft October 5, 2024 11:17
@FH-Inway FH-Inway force-pushed the fix-unit-test-generation branch from 6daacaa to f5afc27 Compare October 5, 2024 11:29
@FH-Inway FH-Inway force-pushed the fix-unit-test-generation branch from 2afb2e2 to e7d124e Compare October 5, 2024 12:31
@FH-Inway FH-Inway changed the title Provides a workaround for failure to generate parameter unit tests; also updates some actions to latest version Provides a workaround for failure to generate parameter unit tests; also some improvements to actions Oct 5, 2024
@FH-Inway FH-Inway marked this pull request as ready for review October 5, 2024 12:42
@FH-Inway FH-Inway marked this pull request as draft October 6, 2024 19:43
@FH-Inway
create unique patch branch name for each pull request branch
8eaee90 
Previously, if there were multiple pull requests A and B active at the same time, a run of this action for B would overwrite the branch with the fixes from a previous run for A.
@FH-Inway FH-Inway force-pushed the fix-unit-test-generation branch from ecc64f9 to 8eaee90 Compare October 7, 2024 16:31
@FH-Inway FH-Inway changed the title Provides a workaround for failure to generate parameter unit tests; also some improvements to actions Improve actions Oct 7, 2024
@FH-Inway FH-Inway marked this pull request as ready for review October 7, 2024 16:37
@FH-Inway FH-Inway merged commit b93c83a into d365collaborative:master Nov 8, 2024
5 checks passed
@FH-Inway FH-Inway added the 0.7.18 Release 0.7.18 label Nov 10, 2024
@FH-Inway FH-Inway deleted the fix-unit-test-generation branch November 17, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.7.18 Release 0.7.18
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FH-Inway