Fix rush build #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: daily-co#2 For reference: Namespace the asm! macro: rust-lang/rust#84019 Stablization of the asm! macro: https://github.com/rust-lang/reference/blob/cf3a28145e06a3294/src/inline-assembly.md https://phip1611.de/blog/include-assembler-source-files-in-rust-project-and-build-with-cargo
vipyne
approved these changes
Jan 21, 2022
Closed
|
Neat! I suspect this change might not be backwards compatible to earlier Rust versions. If so it might make sense to document the new minimum required Rust version here: https://github.com/daily-co/synthetic-network/blob/main/default.nix#L27 |
|
One more vote for Jason's fix working as of today. Thanks for posting the fix @jasonm! ref: https://gist.github.com/jasonm/d0a53c6729199af9742daf951114ee69 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2
For reference:
Namespace the asm! macro:
rust-lang/rust#84019
Stablization of the asm! macro:
https://github.com/rust-lang/reference/blob/cf3a28145e06a3294/src/inline-assembly.md
https://phip1611.de/blog/include-assembler-source-files-in-rust-project-and-build-with-cargo