Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0029] Add separate enums for the different types of interpretation #1

Closed
wants to merge 2 commits into from

Conversation

damyanp
Copy link
Owner

@damyanp damyanp commented Feb 27, 2025

NOTE: this currently targets a copy of @anupamachandra's PR branch for microsoft#407.
Once that PR is completed, this one will be retargetted to hlsl-spec's main.

It looks like we'll need to start the review process from scratch once we retarget the microsoft/hlsl-specs repo.

Previously, the spec used a single enum to represent types in various contexts:

  • to describe how to interpret input/output vectors
  • to describe how to interpret matrices/bias vectors loaded from memory
  • to describe the element type of HLSL vectors in calls to CheckFeatureSupport

Each of these has a separate set of valid values. This change uses different enums to express these different possible values.

Closes microsoft#402

@damyanp
Copy link
Owner Author

damyanp commented Feb 27, 2025

Now tracked by this PR: microsoft#409

@damyanp damyanp closed this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants