Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vesktop: identical background-primary and text-secondary results in invisible text in new Discord "activity" feature #474

Closed
LeviOP opened this issue Jul 20, 2024 · 2 comments · Fixed by #482
Closed

vesktop: identical background-primary and text-secondary results in invisible text in new Discord "activity" feature #474

LeviOP opened this issue Jul 20, 2024 · 2 comments · Fixed by #482

Comments

@LeviOP
Copy link

LeviOP commented Jul 20, 2024

Because the values of --background-primary and --text-secondary are both var(--base00), this new UI element which uses secondary on top of primary makes the text invisible.
same
@trueNAHO
Copy link
Collaborator

Feel free to submit a PR. With #249 pending, chose something that looks reasonable.

For reference, here are the related declarations:

@danth
Copy link
Owner

danth commented Jul 20, 2024

Is it possible to set a different color just for this element?

mateusauler added a commit to mateusauler/stylix that referenced this issue Jul 22, 2024
@mateusauler
vesktop: improve contrast
2f5c227 
Some generated text colors in dark themes are too close to the background color, making
it hard to read.

Fixes: danth#474
@trueNAHO trueNAHO mentioned this issue Jul 22, 2024
Merged
danth pushed a commit that referenced this issue Jul 24, 2024
@mateusauler
vesktop: improve contrast (#482)
c974c17 
Some generated text colors in dark themes are too close to the background color, making
it hard to read.

Fixes: #474
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vesktop: improve contrast mateusauler/stylix
3 participants
@danth @LeviOP @trueNAHO