gpg-agent: init #831
Open
gpg-agent: init #831
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
trueNAHO
commented
Feb 3, 2025
trueNAHO
commented
With commit b7f50a5 ("qt: add flexible theming with sensible defaults (danth#780)"), the Qt pinentry package is a reasonable default value: > NixOS stopped building gtk2 pinentry by default in > NixOS/nixpkgs#270266 and there does not appear > to be a reasonable other default. > > -- home-manager, "gpg-agent: don't set a default for pinentry", > nix-community/home-manager@4585445 Closes: danth#184
|
Friendly ping: @danth |
danth
reviewed
Feb 15, 2025
|
|
||
| config = lib.mkIf ( | ||
| config.stylix.enable && config.stylix.targets.gpg-agent.enable | ||
| ) { services.gpg-agent.pinentryPackage = pkgs.pinentry-qt; }; |
There was a problem hiding this comment.
Doesn't this go against the usual policy of not changing non-theming-related settings?
This may break the default pinentry in GNOME, which currently looks like this:
(which follows my chosen color scheme)
There was a problem hiding this comment.
This may break the default pinentry in GNOME
Does it still look like that after restarting GNOME?
There was a problem hiding this comment.
The
echo GETPIN | nix run nixpkgs#pinentry-qtcommand results in the following with this PR:
Otherwise, it is not themed at all.
AFAIK, the graphical environment (Hyprland in my case) needs to be restarted for the Qt changes from this PR to be applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.