-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt: adds default value for qt.platform #884
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase this on top of master? I assume only commit 0d75bef needs to be cherry-picked.
How does this PR compare to nix-community/home-manager#6493? |
Unrelated I have subscribed to nix-community/home-manager#6493 and will adapt in a new PR that also fixes #869 |
b98d8a7
to
5bd8c8b
Compare
Adds a default value so the option can be referenced when unset
5bd8c8b
to
9fd8133
Compare
Defaults are already handled for the qt nixos modules here with extra logic I believe Lines 40 to 49 in f121a14
Wouldn't it be better to move this block of code up, or otherwise mark this value as I haven't tested it yet, but as it stands I think this value will collide with what is set in the option if the two differ anyways. |
Keep in mind that this only a temporary fix for like 2-3 weeks to ensure backwards compatibility and avoid build errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra additions related to d171b19.
Adds a default value so it does not fail like in issue #835