-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add performance test #168
Merged
Merged
Add performance test #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reorganize tests folder structure - split tests into end-to-end, unit and performance - Add performance test
- Use `PerformanceObserver` to get duration to make actual execution time visible in failed test
- Set performance test threshold to value actual for CI
- Measure performance with `format = html` to cover default use case
- Increase threshold for CI
- Add `windows` and `osx` to Travis build matrix
- Increase threshold more
- Try to normalize EOLs on CI
- Increase threshold further
- Remove obsolete key `sudo`
- Force using LF on CI
- Force LF for CI
- Revert changes to `.travis.yml`. Will be added as a separate commit - Increase threshold
danvk
approved these changes
Feb 25, 2020
- Add `_MS` to constant name
- Set threshould to 6000 so that we have ~1000ms buffer from the worst result on CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #166