chore: tighten pragma #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As-is, the code will not work with any version after 0.7.0 (inclusive).
* >=0.7.0 errors due to usage of `now` which has been deprecated in favor of `block.timestamp`
* >=0.8.0 errors due to:
* `type conversion from "int_const -1" to "uint256"`, which can be replaced with `type(uint256).max`
* `type conversion from int_const 0" to "contract DSAuthority"`
|
thanks! |
gakonst
added a commit
to gakonst/ds-token
that referenced
this pull request
Jan 8, 2022
same motivation as dapphub#35
metacoffee0x17
pushed a commit
to metacoffee0x17/Solidity-ds-token
that referenced
this pull request
Oct 1, 2022
same motivation as dapphub/ds-token#35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As-is, the code will not work with any version after 0.7.0 (inclusive).
>=0.7.0errors due to usage ofnowwhich has been deprecated in favor ofblock.timestamp>=0.8.0errors due to:type conversion from "int_const -1" to "uint256", which can be replaced withtype(uint256).maxtype conversion from int_const 0" to "contract DSAuthority"