Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore uri_does_not_exist in analyzer/DDC #1984

Closed
wants to merge 2 commits into from

Conversation

natebosch
Copy link
Member

  • Drop strong-mode option - it is the default.
  • Add ignore for uri_does_not_exist.

Since imports are crawled while finding modules we have separate error
reporting already for missing imports. We don't need DDC to find these
for us.

- Drop `strong-mode` option - it is the default.
- Add ignore for `uri_does_not_exist`.

Since imports are crawled while finding modules we have separate error
reporting already for missing imports. We don't need DDC to find these
for us.
@natebosch natebosch requested a review from jakemac53 January 18, 2019 23:37
@googlebot googlebot added the cla: yes Google is happy with the PR contributors label Jan 18, 2019
@natebosch
Copy link
Member Author

Here's what the error looks like today:

[SEVERE] build_web_compilers|entrypoint on web/main.dart:
Unable to find modules for some sources, this is usually the result of either a
bad import, a missing dependency in a package (or possibly a dev_dependency
needs to move to a real dependency), or a build failure (if importing a
generated file).

Please check the following imports:

`import 'bad.dart';` from dart_repro|web/main.dart at 1:1

@jakemac53
Copy link
Contributor

I think this is reasonable, can you also remove the comments here just to confirm all is good https://github.com/dart-lang/build/blob/master/_test/test/config_specific_import_test.dart#L7

@natebosch
Copy link
Member Author

Ugh, DDC seems to ignore this. I don't know if it ignores --options altogether, or only ignores if you try to change error levels.

In any case I don't think we can hack around it on our end.

@natebosch
Copy link
Member Author

On the plus side, the original request from dart-lang/sdk#29713 is now essentially granted. On the downside we can't hack around dart-lang/sdk#34177 using this strategy.

@natebosch natebosch closed this Jan 19, 2019
@natebosch natebosch deleted the ignore-missing-imports-analyzer branch January 19, 2019 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google is happy with the PR contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants