#2138. Add more tests for call method/getter
#3053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Looks good!
I've commented on the first test because I think it's a good idea to stick to a small number of language features in a language test (to remain focused). In the remaining tests there might be some elements which have taken inspiration from the first test and I'm suggesting that a couple of things a simplified slightly.
Language/Expressions/Function_Invocation/Function_Expression_Invocation/call_A04_t01.dart
Show resolved
Hide resolved
Language/Expressions/Function_Invocation/Function_Expression_Invocation/call_A04_t02.dart
Outdated
Show resolved
Hide resolved
Language/Expressions/Function_Invocation/Function_Expression_Invocation/call_A04_t02.dart
Outdated
Show resolved
Hide resolved
Language/Expressions/Function_Invocation/Function_Expression_Invocation/call_A04_t03.dart
Outdated
Show resolved
Hide resolved
sgrekhov
commented
Jan 24, 2025
Language/Expressions/Function_Invocation/Function_Expression_Invocation/call_A04_t02.dart
Outdated
Show resolved
Hide resolved
Language/Expressions/Function_Invocation/Function_Expression_Invocation/call_A04_t02.dart
Outdated
Show resolved
Hide resolved
Language/Expressions/Function_Invocation/Function_Expression_Invocation/call_A04_t01.dart
Show resolved
Hide resolved
Language/Expressions/Function_Invocation/Function_Expression_Invocation/call_A04_t03.dart
Outdated
Show resolved
Hide resolved
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jan 31, 2025
2025-01-29 [email protected] dart-lang/co19#3054. Add covariant parameters tests (dart-lang/co19#3059) 2025-01-29 [email protected] dart-lang/co19#3054. Existing tests renamed to Instance Method Closurization (dart-lang/co19#3058) 2025-01-27 [email protected] dart-lang/co19#2162. Add static member and non-redirecting factory constructor conflict test (dart-lang/co19#3056) 2025-01-27 [email protected] dart-lang/co19#2145. Update existing "Evaluation of Implicit Variable Getters" tests (dart-lang/co19#3052) 2025-01-24 [email protected] dart-lang/co19#2138. Add more tests for `call` method/getter (dart-lang/co19#3053) 2025-01-24 [email protected] dart-lang/co19#2162. Add more constructor vs. static member conflict tests (dart-lang/co19#3055) 2025-01-17 [email protected] dart-lang/co19#2976. Add more tests for nullable and FutureOr types (dart-lang/co19#3050) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: Ibeafe23be5d8b913db4e83b23f3820cafc3802ac Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406940 Reviewed-by: Erik Ernst <[email protected]> Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the test mentioned in dart-lang/sdk#55803 (comment)