Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to language 3.7, reformat, upgrade #4525

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Migrate to language 3.7, reformat, upgrade #4525

merged 1 commit into from
Feb 20, 2025
+10,667 −10,861

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Feb 18, 2025

  • Migrate to language version 3.7
  • Apply dart format to get tall mode
  • Reflow some comments and strings that ended up above 80 chars
  • Upgrade all dependencies
  • Removes require_trailing_commas lint, as now the formatter should be enough.

@sigurdm sigurdm requested review from jonasfj and szakarias February 18, 2025 14:39
szakarias
szakarias approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@szakarias szakarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sigurdm sigurdm merged commit 639536a into dart-lang:master Feb 20, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szakarias szakarias szakarias approved these changes

@jonasfj jonasfj Awaiting requested review from jonasfj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sigurdm @szakarias