Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add legal info documentation (DEV-4502) #3513

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Feb 20, 2025

Description

  • feat: Add legal info documentation

@seakayone seakayone changed the title feat: Add legal info documentation feat: Add legal info documentation (DEV-4502) Feb 20, 2025
Copy link

linear bot commented Feb 20, 2025

@seakayone seakayone changed the base branch from main to feat/add-checking-valid-legal-info-when-creating-assets February 20, 2025 11:14
Base automatically changed from feat/add-checking-valid-legal-info-when-creating-assets to main February 20, 2025 11:28
@seakayone seakayone force-pushed the feat/legal-info-docs branch from 888697b to 3198572 Compare February 20, 2025 12:29
@seakayone seakayone marked this pull request as ready for review February 20, 2025 12:30
Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +11 to +13
!!! warning "Legal Information Will Become Mandatory"

Currently, the legal information on the FileValue is optional. This will change in the future when License, Authorship, and Copyright Holder will become mandatory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This info could be added to the deprecations page, because - while technically not a deprecation, just an API change - eventually it will no longer be possible to create assets without legal info. So I think it would fit quite well with the other deprecations.

@seakayone seakayone merged commit c41886b into main Feb 20, 2025
8 checks passed
@seakayone seakayone deleted the feat/legal-info-docs branch February 20, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants